From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932231Ab3LQS1w (ORCPT ); Tue, 17 Dec 2013 13:27:52 -0500 Received: from smtp.outflux.net ([198.145.64.163]:53853 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932202Ab3LQS1t (ORCPT ); Tue, 17 Dec 2013 13:27:49 -0500 Date: Tue, 17 Dec 2013 10:27:33 -0800 From: Kees Cook To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Bradley Grove , "James E.J. Bottomley" , linux-scsi@vger.kernel.org Subject: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw Message-ID: <20131217182733.GA16202@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This makes sure format strings cannot leak into the printk call via the constructed buffer. Signed-off-by: Kees Cook --- drivers/scsi/esas2r/esas2r_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c index 9bf285df58dd..61fc19d296bd 100644 --- a/drivers/scsi/esas2r/esas2r_log.c +++ b/drivers/scsi/esas2r/esas2r_log.c @@ -171,7 +171,7 @@ static int esas2r_log_master(const long level, if (strlen(event_buffer) < buflen) strcat(buffer, "\n"); - printk(event_buffer); + printk("%s", event_buffer); spin_unlock_irqrestore(&event_buffer_lock, flags); } -- 1.7.9.5 -- Kees Cook Chrome OS Security