Re: [RFC][PATCH 0/2] localmodconfig / ALSA: hda - Have codecs be disabled by localmodconfig

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 18 Dec 2013 20:05:11 +0100
Takashi Iwai <tiwai@suse.de> wrote:

 
> Well, as mentioned in the mail thread, I'm afraid that people don't
> like to see yet doubled kconfig items just for workarounds by this
> approach.  So it'd be likely better not to restrict but just let users
> choose tristate.  I already submitted the patches (the same ones as
> attached before) to alsa-devel ML.

Sure, that's why I added the RFC.

> 
> Another thing we may add is a warning like:
> 
> ================================================================
> config SND_HDA_CODEC_REALTEK
> 	tristate "Build Realtek HD-audio codec support"
> 	select SND_HDA_GENERIC
> 	help
> 	  Say Y or M here to include Realtek HD-audio codec support in
> 	  snd-hda-intel driver, such as ALC880.
> 
> comment "Set to Y if you want auto-loading the codec driver"
> 	depends on SND_HDA_CODEC_REALTEK && SND_HDA_INTEL != SND_HDA_CODEC_REALTEK
> ================================================================
> 
> The comment won't break make localmodconfig, right?

Nope, it shouldn't affect localmodconfig at all.

> This should be intuitive enough for avoiding pitfalls, I hope.

But the first patch still needs to be added. I'll just send that out by
itself.

Thanks,

-- Steve