From: David Miller <davem@davemloft.net>
To: fanwlexca@gmail.com
Cc: michael.opdenacker@free-electrons.com, gaofeng@cn.fujitsu.com,
akpm@linux-foundation.org, t.sailer@alumni.ethz.ch,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/hamradio: Integer overflow in hdlcdrv_ioctl()
Date: Thu, 19 Dec 2013 15:03:01 -0500 (EST) [thread overview]
Message-ID: <20131219.150301.1452969308105598247.davem@davemloft.net> (raw)
In-Reply-To: <1387250728-10795-1-git-send-email-fanwlexca@gmail.com>
From: Wenliang Fan <fanwlexca@gmail.com>
Date: Tue, 17 Dec 2013 11:25:28 +0800
> The local variable 'bi' comes from userspace. If userspace passed a
> large number to 'bi.data.calibrate', there would be an integer overflow
> in the following line:
> s->hdlctx.calibrate = bi.data.calibrate * s->par.bitrate / 16;
>
> Signed-off-by: Wenliang Fan <fanwlexca@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-12-19 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 3:25 Wenliang Fan
2013-12-19 20:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219.150301.1452969308105598247.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=fanwlexca@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=t.sailer@alumni.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®