From: Greg KH <gregkh@linuxfoundation.org>
To: Roger Quadros <rogerq@ti.com>
Cc: Huang Rui <ray.huang@amd.com>,
stern@rowland.harvard.edu, balbi@ti.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: usbtest: Always clear halt else further tests will fail
Date: Wed, 18 Dec 2013 22:35:25 -0800 [thread overview]
Message-ID: <20131219063525.GB18820@kroah.com> (raw)
In-Reply-To: <52B29079.2040704@ti.com>
On Thu, Dec 19, 2013 at 11:51:45AM +0530, Roger Quadros wrote:
> On 12/19/2013 11:16 AM, Huang Rui wrote:
> > On Thu, Dec 19, 2013 at 12:01:47PM +0800, Huang Rui wrote:
> >> On Wed, Dec 18, 2013 at 03:40:11PM +0530, Roger Quadros wrote:
> >>> In test_halt() we set an endpoint halt condition and return on halt verification
> >>> failure, then the enpoint will remain halted and all further tests related
> > ^^^^^^^
> >>> to that enpoint will fail. This is because we don't tackle endpoint halt error condition
> > ^^^^^^^
> > BTW, please fix these typo.
>
> Hi Rui,
>
> These patches have been already applied to Greg's usb tree without your Ack's or the typo fix.
>
> Greg,
>
> do you want me to resend the patches?
Nope, it's not a big deal, typo's in changelog comments isn't a worry.
greg k-h
next prev parent reply other threads:[~2013-12-19 6:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 10:10 [PATCH 1/2] usb: usbtest: Add timetout to simple_io() Roger Quadros
2013-12-18 10:10 ` [PATCH 2/2] usb: usbtest: Always clear halt else further tests will fail Roger Quadros
2013-12-19 4:01 ` Huang Rui
2013-12-19 5:46 ` Huang Rui
2013-12-19 6:21 ` Roger Quadros
2013-12-19 6:35 ` Greg KH [this message]
2013-12-18 14:46 ` [PATCH 1/2] usb: usbtest: Add timetout to simple_io() Huang Rui
2013-12-18 16:37 ` Felipe Balbi
2013-12-19 4:00 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219063525.GB18820@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®