From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030220Ab3LTOQL (ORCPT ); Fri, 20 Dec 2013 09:16:11 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:47195 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030197Ab3LTOQI (ORCPT ); Fri, 20 Dec 2013 09:16:08 -0500 Date: Fri, 20 Dec 2013 09:15:57 -0500 From: Neil Horman To: Greg Kroah-Hartman Cc: Bjorn Helgaas , Veaceslav Falico , "linux-pci@vger.kernel.org" , Yinghai Lu , Knut Petersen , Linux Kernel Mailing List Subject: Re: [PATCH v3] PCI: export MSI mode using attributes, not kobjects Message-ID: <20131220141557.GA6562@hmsreliant.think-freely.org> References: <20131219203017.GA1768@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20131219203017.GA1768@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 19, 2013 at 12:30:17PM -0800, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > The PCI MSI sysfs code is a mess with kobjects for things that don't > really need to be kobjects. This patch creates attributes dynamically > for the MSI interrupts instead of using kobjects. > > Note, this removes a directory from the current MSI interrupt sysfs > code: > > old MSI kobjects: > pci_device > └── msi_irqs >    └── 40 >    └── mode > > new MSI attributes: > pci_device > └── msi_irqs >    └── 40 > > As there was only one file "mode" with the kobject model, the interrupt > number is now a file that returns the "mode" of the interrupt (msi vs. > msix). > > Signed-off-by: Greg Kroah-Hartman > Acked-by: Neil Horman Thanks Greg. Neil