From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756580Ab3LUPzS (ORCPT ); Sat, 21 Dec 2013 10:55:18 -0500 Received: from cassiel.sirena.org.uk ([80.68.93.111]:34090 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756511Ab3LUPzO (ORCPT ); Sat, 21 Dec 2013 10:55:14 -0500 Date: Sat, 21 Dec 2013 15:54:42 +0000 From: Mark Brown To: Fabio Estevam Cc: Shawn Guo , Anson Huang , linux-kernel , Fabio Estevam Message-ID: <20131221155442.GP30815@sirena.org.uk> References: <1387546930-32513-1-git-send-email-festevam@gmail.com> <20131221074900.GA6849@S2101-09.ap.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You will outgrow your usefulness. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 217.42.81.147 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regulator: anatop-regulator: Remove unneeded check X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 21, 2013 at 12:25:50PM -0200, Fabio Estevam wrote: > I see. Then we can do this instead, so that the successful probe and > the error path are clearer: Yes, that's going to cause fewer surprises.