From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726Ab3LXNiL (ORCPT ); Tue, 24 Dec 2013 08:38:11 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:48651 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752432Ab3LXNiI (ORCPT ); Tue, 24 Dec 2013 08:38:08 -0500 Date: Tue, 24 Dec 2013 08:37:56 -0500 From: Neil Horman To: Ben Hutchings Cc: linux-sctp@vger.kernel.org, Vlad Yasevich , David Miller , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/2] sctp: Consolidate and ratelimit deprecation warnings Message-ID: <20131224133756.GA10477@hmsreliant.think-freely.org> References: <1387205049-22752-1-git-send-email-nhorman@tuxdriver.com> <1387805383-21500-1-git-send-email-nhorman@tuxdriver.com> <1387839316.1635.8.camel@bwh-desktop.uk.level5networks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387839316.1635.8.camel@bwh-desktop.uk.level5networks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 23, 2013 at 10:55:16PM +0000, Ben Hutchings wrote: > On Mon, 2013-12-23 at 08:29 -0500, Neil Horman wrote: > > The SCTP protocol has several deprecation warnings in its setsockopt path that > > can be triggered by unprivlidged users. Since these are not ratelimited, we can > > spam the logs quite easily here. Since these are all deprecation warnings, and > > that type of warning isn't uncommon in the rest of the kernel, lets make a > > common pr_warn_deprecated macro to produce somewhat generalized ratelimited > > deprecation warnings easily > [...] > > No objection to these changes, but I think deprecation warnings should > log at least the command name and maybe also the pid of the caller. > I didn't change the contents of the strings in this patch, I just wanted to avoid log spamming, but I think adding caller pid/name is a good idea. I'll do that in a followon patch after the holidays Neil > Ben. > > -- > Ben Hutchings, Staff Engineer, Solarflare > Not speaking for my employer; that's the marketing department's job. > They asked us to note that Solarflare product names are trademarked. > >