From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752509Ab3LXNwA (ORCPT ); Tue, 24 Dec 2013 08:52:00 -0500 Received: from cassiel.sirena.org.uk ([80.68.93.111]:41649 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970Ab3LXNv6 (ORCPT ); Tue, 24 Dec 2013 08:51:58 -0500 Date: Tue, 24 Dec 2013 13:51:27 +0000 From: Mark Brown To: Wenyou Yang Cc: lgirdwood@gmail.com, grant.likely@linaro.org, rob.herring@calxeda.com, plagnioj@jcrosoft.com, nicolas.ferre@atmel.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20131224135127.GC24814@sirena.org.uk> References: <1387852421-18033-1-git-send-email-wenyou.yang@atmel.com> <1387852468-18073-1-git-send-email-wenyou.yang@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387852468-18073-1-git-send-email-wenyou.yang@atmel.com> X-Cookie: You may be recognized soon. Hide. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 81.132.50.212 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v5 1/3] regulator: act8865: add PMIC act8865 driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 24, 2013 at 10:34:28AM +0800, Wenyou Yang wrote: > Signed-off-by: Wenyou Yang I've applied this, however there is one small issue which I seem to have forgotten to point out previously: > + /* Finally register devices */ > + for (i = 0; i < pdata->num_regulators; i++) { The driver should register all regulators regardless of how many are used in the system in order to aid diagnostics. Please send an incremental patch to fix this.