From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] block: blk-mq: support draining mq queue
Date: Thu, 26 Dec 2013 02:53:16 -0800 [thread overview]
Message-ID: <20131226105316.GA16268@infradead.org> (raw)
In-Reply-To: <CACVXFVOOEGPt7JXKmk=dTz3H6TgadBoOx1_D_hksi6J1L7OjYw@mail.gmail.com>
On Thu, Dec 26, 2013 at 06:12:30PM +0800, Ming Lei wrote:
> IMO, if one block API can serve for both non-MQ and MQ cases, why do
> we have to split it into blk_foo() and blk_mq_foo()?
To make the usage obvious and to allow killing the old code more
easily. Looking back I have to see I'd actually prefer it the MQ
code simply used different data structures.
>
> IMO it is very possible that parallel path might keep for a while, and at least
> the current scsi-mq patches do so.
That might be okay for the current prototype, but there's not point in
merging it if it can't replace the old legacy request code. And yes,
this will require a lot more work.
next prev parent reply other threads:[~2013-12-26 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 16:18 [PATCH 0/4] block: blk-mq: support blk_cleanup_queue on mq Ming Lei
2013-12-23 16:18 ` [PATCH 1/4] block: blk-mq: support draining mq queue Ming Lei
2013-12-23 16:24 ` Christoph Hellwig
2013-12-24 3:30 ` Ming Lei
2013-12-26 9:45 ` Christoph Hellwig
2013-12-26 10:12 ` Ming Lei
2013-12-26 10:53 ` Christoph Hellwig [this message]
2013-12-23 16:18 ` [PATCH 2/4] block: blk-mq: make blk_sync_queue support mq Ming Lei
2013-12-23 16:25 ` Christoph Hellwig
2013-12-24 3:35 ` Ming Lei
2013-12-23 16:18 ` [PATCH 3/4] block: null_blk: fix queue leak inside removing device Ming Lei
2013-12-23 16:26 ` Christoph Hellwig
2013-12-23 16:18 ` [PATCH 4/4] block: blk-mq: don't export blk_mq_free_queue() Ming Lei
2013-12-23 16:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226105316.GA16268@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®