mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kirill Tkhai <tkhai@yandex.ru>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: mingo@redhat.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org,
	Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/5] sched, rt: move .switched_from out of the scope of CONFIG_SMP
Date: Sat, 28 Dec 2013 13:19:48 +0400	[thread overview]
Message-ID: <20131228091948.GA3832@HP-250-G1-Notebook-PC.beeline> (raw)
In-Reply-To: <1388144464-28458-2-git-send-email-zwu.kernel@gmail.com>

On Пт, дек 27, 2013 at 07:41:00 +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> 
> .switched_from shouldn't be initialized in the scope of CONFIG_SMP,
> so this patch is trying to move it out.
> 
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>  kernel/sched/rt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 1c40655..f34d41b 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -2002,9 +2002,9 @@ const struct sched_class rt_sched_class = {
>  	.pre_schedule		= pre_schedule_rt,
>  	.post_schedule		= post_schedule_rt,
>  	.task_woken		= task_woken_rt,
> -	.switched_from		= switched_from_rt,
>  #endif
>  
> +	.switched_from		= switched_from_rt,
>  	.set_curr_task          = set_curr_task_rt,
>  	.task_tick		= task_tick_rt,

This will not be compilable in !SMP mode because the body of switched_from_rt()
is still under CONFIG_SMP define.

Kirill

  reply	other threads:[~2013-12-28  9:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-27 11:40 [PATCH 0/5] Sched: Some trivial typo fixes Zhi Yong Wu
2013-12-27 11:41 ` [PATCH 1/5] sched, rt: move .switched_from out of the scope of CONFIG_SMP Zhi Yong Wu
2013-12-28  9:19   ` Kirill Tkhai [this message]
2013-12-28  9:37     ` Zhi Yong Wu
2013-12-28  9:48       ` Kirill Tkhai
2013-12-28  9:59         ` Zhi Yong Wu
2013-12-27 11:41 ` [PATCH 2/5] sched, fair: fix the comment of move_tasks() Zhi Yong Wu
2013-12-27 11:41 ` [PATCH 3/5] sched, fair: fix the typo in select_idle_sibling() Zhi Yong Wu
2013-12-27 11:41 ` [PATCH 4/5] sched, fair: fix the comment of select_task_rq_fair() Zhi Yong Wu
2013-12-27 11:41 ` [PATCH 5/5] Documentation, sched-arch.txt: fix the incorrect syntax Zhi Yong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131228091948.GA3832@HP-250-G1-Notebook-PC.beeline \
    --to=tkhai@yandex.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=wuzhy@linux.vnet.ibm.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®