From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755983Ab3L3N3V (ORCPT ); Mon, 30 Dec 2013 08:29:21 -0500 Received: from mail-bk0-f47.google.com ([209.85.214.47]:49319 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542Ab3L3N3T (ORCPT ); Mon, 30 Dec 2013 08:29:19 -0500 Date: Mon, 30 Dec 2013 14:29:15 +0100 From: Julian Andres Klode To: Julian Andres Klode Cc: Henrique de Moraes Holschuh , Matthew Garrett , "open list:THINKPAD ACPI EXT..." , "open list:THINKPAD ACPI EXT..." , open list Subject: Re: [PATCH 1/4] thinkpad_acpi: Add support for controlling charge thresholds Message-ID: <20131230132915.GB24241@jak-x230> Mail-Followup-To: Julian Andres Klode , Henrique de Moraes Holschuh , Matthew Garrett , "open list:THINKPAD ACPI EXT..." , "open list:THINKPAD ACPI EXT..." , open list References: <1384178195-12218-1-git-send-email-jak@jak-linux.org> <1384178195-12218-2-git-send-email-jak@jak-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384178195-12218-2-git-send-email-jak@jak-linux.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2013 at 02:56:30PM +0100, Julian Andres Klode wrote: > Add support for battery charge thresholds in new Sandy Bridge and Ivy Bridge > ThinkPads. Based on the unofficial documentation in tpacpi-bat. > > The threshold files support the values '0' for the controller's default, > and 1-99 as percentages. Values outside of that range are rejected. The > behaviour of '0' might be confusing, especially for the stop case where > it basically seems to mean '100'. Thinking more about this, it might make more sense to simply accept a 100 value and not accept a 0 value in the stop case (I tried multiple times to write 100 to a stop_charge_thresh file, because that feels more natural). Having a 0 mean 100% is just odd. So stop_charge_thresh should simply accepts integer values in the range [1, 100] (and start_charge_thresh should continue accept [0, 99], as 0 really means 0 there). -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. Please do not top-post if possible.