From: Jack Morgenstein <jackm@dev.mellanox.co.il>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Roland Dreier <roland@kernel.org>,
kernel-janitors@vger.kernel.org,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [PATCH 5/25] IB/mlx4: fix error return code
Date: Tue, 31 Dec 2013 09:52:34 +0200 [thread overview]
Message-ID: <20131231095234.28f33123@jpm-OptiPlex-GX620> (raw)
In-Reply-To: <1388357260-4843-6-git-send-email-Julia.Lawall@lip6.fr>
On Sun, 29 Dec 2013 23:47:20 +0100
Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> diff --git a/drivers/infiniband/hw/mlx4/sysfs.c
> b/drivers/infiniband/hw/mlx4/sysfs.c index 97516eb..db2ea31 100644
> --- a/drivers/infiniband/hw/mlx4/sysfs.c
> +++ b/drivers/infiniband/hw/mlx4/sysfs.c
> @@ -582,8 +582,10 @@ static int add_port(struct mlx4_ib_dev *dev, int
> port_num, int slave) p->pkey_group.attrs =
> alloc_group_attrs(show_port_pkey, store_port_pkey,
> dev->dev->caps.pkey_table_len[port_num]);
> - if (!p->pkey_group.attrs)
> + if (!p->pkey_group.attrs) {
> + ret = -ENOMEM;
> goto err_alloc;
> + }
>
> ret = sysfs_create_group(&p->kobj, &p->pkey_group);
> if (ret)
> @@ -591,8 +593,10 @@ static int add_port(struct mlx4_ib_dev *dev, int
> port_num, int slave)
> p->gid_group.name = "gid_idx";
> p->gid_group.attrs = alloc_group_attrs(show_port_gid_idx,
> NULL, 1);
> - if (!p->gid_group.attrs)
> + if (!p->gid_group.attrs) {
> + ret = -ENOMEM;
> goto err_free_pkey;
> + }
>
ACK. Julia's patch is correct -- this is indeed a bug-fix.
-Jack
next prev parent reply other threads:[~2013-12-31 7:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 22:47 [PATCH 0/25] " Julia Lawall
2013-12-29 22:47 ` [PATCH 1/25] " Julia Lawall
2013-12-29 22:47 ` [PATCH 2/25] rsxx: " Julia Lawall
2013-12-29 22:47 ` [PATCH 3/25] " Julia Lawall
2013-12-29 22:47 ` [PATCH 4/25] UBI: " Julia Lawall
2013-12-31 11:30 ` Richard Weinberger
2014-01-02 15:16 ` Artem Bityutskiy
2013-12-29 22:47 ` [PATCH 5/25] IB/mlx4: " Julia Lawall
2013-12-31 7:52 ` Jack Morgenstein [this message]
2013-12-29 22:47 ` [PATCH 6/25] " Julia Lawall
2014-01-03 9:08 ` Jiri Kosina
2013-12-29 22:47 ` [PATCH 7/25] net: " Julia Lawall
2014-01-02 8:31 ` David Miller
2013-12-29 22:47 ` [PATCH 8/25] drivers/dma: " Julia Lawall
2014-01-20 9:28 ` Vinod Koul
2013-12-29 22:47 ` [PATCH 9/25] " Julia Lawall
2013-12-29 22:47 ` [PATCH 10/25] usb: gadget: " Julia Lawall
2013-12-29 22:47 ` [PATCH 11/25] pcmcia: " Julia Lawall
2013-12-29 22:47 ` [PATCH 12/25] HID: sony: " Julia Lawall
2014-01-02 12:51 ` Jiri Kosina
2013-12-29 22:47 ` [PATCH 13/25] hamradio: 6pack: " Julia Lawall
2014-01-02 8:31 ` David Miller
2013-12-29 22:47 ` [PATCH 14/25] RDMA/amso1100: " Julia Lawall
2013-12-29 22:47 ` [PATCH 17/25] " Julia Lawall
2013-12-29 22:47 ` [PATCH 16/25] block: " Julia Lawall
2013-12-29 22:47 ` [PATCH 15/25] " Julia Lawall
2013-12-29 22:47 ` [PATCH 18/25] mtd: nand: " Julia Lawall
2013-12-29 22:47 ` [PATCH 19/25] " Julia Lawall
2013-12-29 21:58 ` Geert Uytterhoeven
2013-12-29 22:47 ` [PATCH 20/25] " Julia Lawall
2013-12-29 22:47 ` [PATCH 21/25] fujitsu-laptop: " Julia Lawall
2013-12-31 13:05 ` Jonathan Woithe
2013-12-29 22:47 ` [PATCH 22/25] RDMA/nes: " Julia Lawall
2013-12-29 22:47 ` [PATCH 23/25] thermal: exynos: " Julia Lawall
2013-12-30 1:31 ` Jingoo Han
2014-01-02 1:55 ` Zhang Rui
2013-12-29 22:47 ` [PATCH 24/25] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231095234.28f33123@jpm-OptiPlex-GX620 \
--to=jackm@dev.mellanox.co.il \
--cc=Julia.Lawall@lip6.fr \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®