From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <tom.leiming@gmail.com>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v1 1/5] block: blk-mq: avoid initializing request during its completion
Date: Tue, 31 Dec 2013 09:38:51 -0700 [thread overview]
Message-ID: <20131231163851.GJ21823@kernel.dk> (raw)
In-Reply-To: <1388064698-27344-2-git-send-email-tom.leiming@gmail.com>
On Thu, Dec 26 2013, Ming Lei wrote:
> One problem is that request->start_time/start_time_ns could be
> set as wrong.
>
> Also it is normal to intialize one data structure just after its
> allocation.
>
> So move the initialization out of its completion path.
It's done that way because of presumed cache hotness on completion,
since we just touched a lot of the members. Lets just fix the start time
issue by itself.
--
Jens Axboe
next prev parent reply other threads:[~2013-12-31 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 13:31 [PATCH v1 0/5] block: blk-mq: support blk_cleanup_queue on mq Ming Lei
2013-12-26 13:31 ` [PATCH v1 1/5] block: blk-mq: avoid initializing request during its completion Ming Lei
2013-12-31 16:38 ` Jens Axboe [this message]
2014-01-01 4:57 ` Ming Lei
2013-12-26 13:31 ` [PATCH v1 2/5] block: blk-mq: support draining mq queue Ming Lei
2013-12-26 13:31 ` [PATCH v1 3/5] block: blk-mq: make blk_sync_queue support mq Ming Lei
2013-12-26 13:31 ` [PATCH v1 4/5] block: null_blk: fix queue leak inside removing device Ming Lei
2013-12-31 16:26 ` Jens Axboe
2013-12-26 13:31 ` [PATCH v1 5/5] block: blk-mq: don't export blk_mq_free_queue() Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231163851.GJ21823@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome