From: Pavel Machek <pavel@ucw.cz>
To: kys@microsoft.com, haiyangz@microsoft.com,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
trivial@kernel.org
Subject: Trivial cleanups for drivers/hv/connection.c
Date: Tue, 31 Dec 2013 22:52:37 +0100 [thread overview]
Message-ID: <20131231215236.GA18573@amd.pavel.ucw.cz> (raw)
__u32 is only useful for kernel-user interface, u32 should be enough
for kernel. Formatting was very confusing around __get_free_pages().
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
index 936093e..1387208 100644
--- a/drivers/hv/connection.c
+++ b/drivers/hv/connection.c
@@ -43,10 +43,10 @@ struct vmbus_connection vmbus_connection = {
/*
* Negotiated protocol version with the host.
*/
-__u32 vmbus_proto_version;
+u32 vmbus_proto_version;
EXPORT_SYMBOL_GPL(vmbus_proto_version);
-static __u32 vmbus_get_next_version(__u32 current_version)
+static u32 vmbus_get_next_version(u32 current_version)
{
switch (current_version) {
case (VERSION_WIN7):
@@ -62,7 +62,7 @@ static __u32 vmbus_get_next_version(__u32 current_version)
}
static int vmbus_negotiate_version(struct vmbus_channel_msginfo *msginfo,
- __u32 version)
+ u32 version)
{
int ret = 0;
struct vmbus_channel_initiate_contact *msg;
@@ -133,7 +133,7 @@ int vmbus_connect(void)
{
int ret = 0;
struct vmbus_channel_msginfo *msginfo = NULL;
- __u32 version;
+ u32 version;
/* Initialize the vmbus connection */
vmbus_connection.conn_state = CONNECTING;
@@ -154,7 +154,7 @@ int vmbus_connect(void)
* abstraction stuff
*/
vmbus_connection.int_page =
- (void *)__get_free_pages(GFP_KERNEL|__GFP_ZERO, 0);
+ (void *)__get_free_pages(GFP_KERNEL|__GFP_ZERO, 0);
if (vmbus_connection.int_page == NULL) {
ret = -ENOMEM;
goto cleanup;
@@ -170,7 +170,7 @@ int vmbus_connect(void)
* parent->child and the 2nd page for child->parent
*/
vmbus_connection.monitor_pages =
- (void *)__get_free_pages((GFP_KERNEL|__GFP_ZERO), 1);
+ (void *)__get_free_pages((GFP_KERNEL|__GFP_ZERO), 1);
if (vmbus_connection.monitor_pages == NULL) {
ret = -ENOMEM;
goto cleanup;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next reply other threads:[~2013-12-31 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 21:52 Pavel Machek [this message]
2014-01-02 15:06 ` Dan Carpenter
2014-01-13 23:02 ` hv: " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231215236.GA18573@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®