From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbaABPYR (ORCPT ); Thu, 2 Jan 2014 10:24:17 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44367 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769AbaABPYQ (ORCPT ); Thu, 2 Jan 2014 10:24:16 -0500 Date: Thu, 2 Jan 2014 16:24:14 +0100 From: David Sterba To: Michal Nazarewicz Cc: fdmanana@gmail.com, Chris Mason , Josef Bacik , "linux-btrfs@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] btrfs: remove dead code Message-ID: <20140102152414.GK6498@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Michal Nazarewicz , fdmanana@gmail.com, Chris Mason , Josef Bacik , "linux-btrfs@vger.kernel.org" , linux-kernel@vger.kernel.org References: <1388553589-26778-1-git-send-email-mina86@mina86.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 01, 2014 at 05:22:18PM +0100, Michal Nazarewicz wrote: > > On Wed, Jan 1, 2014 at 5:19 AM, Michal Nazarewicz wrote: > >> [commit 8185554d: fix incorrect inode acl reset] introduced a dead > >> code by adding a condition which can never be true to an else > >> branch. The condition can never be true because it is already > >> checked by a previous if statement which causes function to return. > > On Wed, Jan 01 2014, Filipe David Manana wrote: > > Josef already added this patch to btrfs-next weeks ago: > > > > http://git.kernel.org/cgit/linux/kernel/git/josef/btrfs-next.git/commit/?id=c4a886e433dce2b902324a54ef2d13691a760312 > > Ah, sorry for the spam then. > > The original thread did not mention it and this commit was not included > in linux-next's master branch. FYI, the patches get merged to btrfs-next without confirmations to the mailiglist, the linux-next tree does not merge the development branches, only when Chris publishes a branch named 'next'. (http://linux.f-seidel.de/linux-next/pmwiki/pmwiki.php?n=Linux-next.IncludedTrees) david