From: Michal Marek <mmarek@suse.cz>
To: Franck Bui-Huu <fbuihuu@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix detectition of kernel git repository in setlocalversion script [take #2]
Date: Fri, 3 Jan 2014 14:49:44 +0100 [thread overview]
Message-ID: <20140103134943.GB1676@sepie.suse.cz> (raw)
In-Reply-To: <1385998469-21515-1-git-send-email-fbuihuu@gmail.com>
On Mon, Dec 02, 2013 at 04:34:29PM +0100, Franck Bui-Huu wrote:
> setlocalversion script was testing the presence of .git directory in order to find out
> if git is used as SCM to track the current kernel project. However in some cases, .git
> is not a directory but can be a file: when the kernel is a git submodule part of a git
> super project for example.
>
> This patch just fixes this by using 'git rev-parse --show-cdup' to check that the
> current directory is the kernel git topdir. This has the advantage to not test and rely
> on git internal infrastructure directly.
>
> Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
> ---
> scripts/setlocalversion | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to kbuild.git#kbuild.
Michal
prev parent reply other threads:[~2014-01-03 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 13:21 [PATCH] Fix detectition of kernel git repository in setlocalversion script Franck Bui-Huu
2013-12-02 14:57 ` Michal Marek
2013-12-02 15:14 ` Franck Bui-Huu
2013-12-02 15:16 ` Michal Marek
2013-12-02 15:23 ` Franck Bui-Huu
2013-12-02 15:34 ` [PATCH] Fix detectition of kernel git repository in setlocalversion script [take #2] Franck Bui-Huu
2014-01-03 13:49 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103134943.GB1676@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=fbuihuu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®