From: Wei Liu <wei.liu2@citrix.com>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Paul Durrant <Paul.Durrant@citrix.com>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
<ian.campbell@citrix.com>, <wei.liu2@citrix.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen-netback: Include header for vmalloc
Date: Sun, 5 Jan 2014 22:22:21 +0000 [thread overview]
Message-ID: <20140105222221.GA16984@zion.uk.xensource.com> (raw)
In-Reply-To: <20140105152401.GF18517@hansolo.jdub.homelinux.org>
On Sun, Jan 05, 2014 at 10:24:01AM -0500, Josh Boyer wrote:
> Commit ac3d5ac27735 ("xen-netback: fix guest-receive-side array sizes")
> added calls to vmalloc and vfree in the interface.c file without including
> <linux/vmalloc.h>. This causes build failures if the
> -Werror=implicit-function-declaration flag is passed.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Thanks
Wei.
> ---
> drivers/net/xen-netback/interface.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 34ca4e5..fff8cdd 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -34,6 +34,7 @@
> #include <linux/ethtool.h>
> #include <linux/rtnetlink.h>
> #include <linux/if_vlan.h>
> +#include <linux/vmalloc.h>
>
> #include <xen/events.h>
> #include <asm/xen/hypercall.h>
> --
> 1.8.4.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-05 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 15:24 Josh Boyer
2014-01-05 22:22 ` Wei Liu [this message]
2014-01-06 1:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140105222221.GA16984@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=davem@davemloft.net \
--cc=ian.campbell@citrix.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®