mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: rui.zhang@intel.com, Mike Turquette <mturquette@linaro.org>,
	Nishanth Menon <nm@ti.com>, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Len Brown <len.brown@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC RESEND PATCH 1/1] thermal: introduce clock cooling device
Date: Mon, 6 Jan 2014 22:31:35 +0100	[thread overview]
Message-ID: <20140106213135.GA14927@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1389013458-14719-1-git-send-email-eduardo.valentin@ti.com>

Hi!

> --- /dev/null
> +++ b/drivers/thermal/clock_cooling.c
> @@ -0,0 +1,484 @@
> +/*
> + *  drivers/thermal/cpu_cooling.c

Bit too much copy&paste...


> + *  Copyright (C) 2013	Texas Instruments Inc.
> + *  Contact:  Eduardo Valentin <eduardo.valentin@ti.com>
> + *
> + *  Highly based on cpu_cooling.c.

Check english. And you should add samsung & linaro copyright here,
since you copied from it.

> + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

can we get rid of ~~~s?

> +static int clock_cooling_get_property(struct clock_cooling_device *ccdev,
> +				      unsigned long input,
> +				      unsigned long *output,
> +				      enum clock_cooling_property property)
> +{
> +	int i, j;
> +	unsigned long max_level = 0, level = 0;
...
> +	if (property == GET_MAXL) {
> +		*output = (unsigned int)max_level;

What is going on with types here? Remove cast?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      reply	other threads:[~2014-01-06 21:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 13:04 Eduardo Valentin
2014-01-06 21:31 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106213135.GA14927@amd.pavel.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=eduardo.valentin@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=nm@ti.com \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®