From: Arnd Bergmann <arnd@arndb.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, Roger Quadros <rogerq@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH v3 1/2] Documentation: Add GPIO reset binding to reset binding documentation
Date: Wed, 8 Jan 2014 17:08:26 +0100 [thread overview]
Message-ID: <201401081708.26679.arnd@arndb.de> (raw)
In-Reply-To: <1389179464-11963-1-git-send-email-p.zabel@pengutronix.de>
On Wednesday 08 January 2014, Philipp Zabel wrote:
> += GPIO Reset consumers =
> +
> +For the common case of reset lines controlled by GPIOs, the GPIO binding
> +documented in devicetree/bindings/gpio/gpio.txt should be used:
> +
> +Required properties:
> +reset-gpios or Reset GPIO using standard GPIO bindings,
> +<name>-reset-gpios: optionally named to specify the reset line
> +
> +Optional properties:
> +reset-boot-asserted or Boolean. If set, the corresponding reset is
> +<name>-reset-boot-asserted: initially asserted and should be kept that way
> + until released by the driver.
I don't get this one. Why would you use a different reset binding for the case
where the reset line is connected to the gpio controller rather than a
specialized reset controller?
I was expecting to see the definition of a generic reset controller that
in turn uses gpio lines, like
reset {
compatible = "gpio-reset";
/* provides three reset lines through these GPIOs */
gpios = <&gpioA 1 &gpioB 7 <gpioD 17>;
#reset-cells = <1>;
};
foo {
...
resets = <&reset 0>; /* uses first reset line of the gpio-reset controller */
};
I realize it would be a little more verbose, but it also seems more
regular and wouldn't stand out from the rest of the reset interfaces.
Arnd
next prev parent reply other threads:[~2014-01-08 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 11:11 Philipp Zabel
2014-01-08 11:11 ` [PATCH v3 2/2] reset: Add GPIO support to reset controller framework Philipp Zabel
2014-01-08 16:08 ` Arnd Bergmann [this message]
2014-01-10 11:25 ` [PATCH v3 1/2] Documentation: Add GPIO reset binding to reset binding documentation Philipp Zabel
2014-02-06 15:44 ` Philipp Zabel
2014-02-14 10:20 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401081708.26679.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=p.zabel@pengutronix.de \
--cc=rogerq@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome