From: Mark Brown <broonie@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-spi@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: Check conflicting CS based on spi->chip_select instead of device name
Date: Thu, 9 Jan 2014 14:06:46 +0000 [thread overview]
Message-ID: <20140109140646.GT31886@sirena.org.uk> (raw)
In-Reply-To: <1389273835-8615-1-git-send-email-mika.westerberg@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
On Thu, Jan 09, 2014 at 03:23:55PM +0200, Mika Westerberg wrote:
> In case of a buggy BIOS that lists multiple SPI devices sharing the same
> chip select (even though they should use different) the current code fails
> to detect that and allows the devices to be added to the bus.
This actually also points out another issue - if we have two instances
of a device on different buses they could end up with the same
dev_name() if they have the same chip select. Hrm.
I'll apply this but we'll probably need to do something about such
conflicts at some point.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-09 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 13:23 Mika Westerberg
2014-01-09 13:59 ` Jarkko Nikula
2014-01-09 16:05 ` Mika Westerberg
2014-01-09 14:06 ` Mark Brown [this message]
2014-01-09 14:27 ` Mika Westerberg
2014-01-09 14:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109140646.GT31886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®