From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [RFC][PATCH] tracing: Show available event triggers when no trigger is set
Date: Thu, 9 Jan 2014 17:06:45 -0500 [thread overview]
Message-ID: <20140109170645.17c819ae@gandalf.local.home> (raw)
In-Reply-To: <87a9f6di94.fsf@sejong.aot.lge.com>
On Wed, 08 Jan 2014 16:50:47 +0900
Namhyung Kim <namhyung@kernel.org> wrote:
> [SNIP]
> > + if (v == SHOW_AVAILABLE_TRIGGERS) {
> > + seq_puts(m, "# Available triggers:\n");
> > + seq_putc(m, '#');
> > + mutex_lock(&trigger_cmd_mutex);
> > + list_for_each_entry(p, &trigger_commands, list)
>
> I guess the list_for_each_entry_reverse() will give a more intuitive
> result here:
>
> [root /sys/kernel/debug/tracing]# cat events/sched/sched_switch/trigger
> # Available triggers:
> # traceon traceoff snapshot stacktrace enable_event disable_event
>
Updated. Thanks for the review.
-- Steve
prev parent reply other threads:[~2014-01-09 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 15:35 Steven Rostedt
2014-01-07 23:34 ` Tom Zanussi
2014-01-08 2:07 ` Steven Rostedt
2014-01-08 7:50 ` Namhyung Kim
2014-01-09 22:06 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109170645.17c819ae@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome