From: Greg KH <gregkh@linuxfoundation.org>
To: Morgan Creekmore <gamingrobot@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rts5139: Fixed style issues
Date: Thu, 9 Jan 2014 10:44:10 -0800 [thread overview]
Message-ID: <20140109184410.GD10563@kroah.com> (raw)
In-Reply-To: <1389017109-16032-1-git-send-email-gamingrobot@gmail.com>
On Mon, Jan 06, 2014 at 07:05:09AM -0700, Morgan Creekmore wrote:
> Fixed style issues for lines over 80 chars
>
> Signed-off-by: Morgan Creekmore <gamingrobot@gmail.com>
> ---
> drivers/staging/rts5139/rts51x_card.c | 10 +++++-----
> drivers/staging/rts5139/rts51x_card.h | 8 ++++----
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rts5139/rts51x_card.c b/drivers/staging/rts5139/rts51x_card.c
> index 509d83e..03456d9 100644
> --- a/drivers/staging/rts5139/rts51x_card.c
> +++ b/drivers/staging/rts5139/rts51x_card.c
> @@ -373,7 +373,7 @@ void rts51x_release_cards(struct rts51x_chip *chip)
>
> static inline u8 double_depth(u8 depth)
> {
> - return ((depth > 1) ? (depth - 1) : depth);
> + return (depth > 1) ? (depth - 1) : depth;
This fix isn't what you said you were doing in the above changelog
description :(
Please be correct in your changelogs.
greg k-h
prev parent reply other threads:[~2014-01-09 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 14:05 Morgan Creekmore
2014-01-09 18:44 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109184410.GD10563@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gamingrobot@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome