From: Pavel Machek <pavel@ucw.cz>
To: Bryan Wu <cooloney@gmail.com>
Cc: "rpurdie@rpsys.net" <rpurdie@rpsys.net>,
"Linux LED Subsystem" <linux-leds@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>, "milo kim" <milo.kim@ti.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Sebastian Reichel" <sre@debian.org>,
"Sebastian Reichel" <sre@ring0.de>
Subject: Re: Broken locking in leds-lp5523.c
Date: Thu, 9 Jan 2014 23:45:41 +0100 [thread overview]
Message-ID: <20140109224541.GA19516@amd.pavel.ucw.cz> (raw)
In-Reply-To: <CAK5ve-Kk9BuH=56F98aZOgPS+w-=8iF0HtpOYWNjRN8am2Zqjg@mail.gmail.com>
Hi!
> > Now, this is untested patch from my reverse-engineering. I hope I
> > understood things right...
> >
> > In particular, there's unbalanced unlock in
> > lp5523_update_program_memory, and lp5523_update_program_memory needs
> > to be protected by the lock.
> >
> > Comments? Does someone maintain this?
> >
>
> Actually the locking issue was fixed in my for-next branch,
> http://git.kernel.org/cgit/linux/kernel/git/cooloney/linux-leds.git/commit/?h=for-next&id=0d70bdb957cde2c25a4b3e4c93d0d33403795be9
>
Yes, that should solve it. Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-01-09 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 20:42 Pavel Machek
2014-01-07 23:57 ` Bryan Wu
2014-01-09 23:08 ` Pavel Machek
2014-01-08 0:32 ` Bryan Wu
2014-01-09 14:24 ` Pali Rohár
2014-01-09 17:51 ` Bryan Wu
2014-01-09 22:45 ` Pavel Machek [this message]
2014-01-09 23:13 ` [trivial] Comment improvements for lp5523 and friend Pavel Machek
2014-02-06 19:36 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109224541.GA19516@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=pali.rohar@gmail.com \
--cc=rpurdie@rpsys.net \
--cc=sre@debian.org \
--cc=sre@ring0.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®