From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757976AbaAJQWb (ORCPT ); Fri, 10 Jan 2014 11:22:31 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:46490 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757868AbaAJQW3 (ORCPT ); Fri, 10 Jan 2014 11:22:29 -0500 Date: Fri, 10 Jan 2014 08:22:26 -0800 From: Guenter Roeck To: Paul Gortmaker Cc: Fenghua Yu , Jean Delvare , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH-next] drivers/hwmon: remove new __cpuinit usage from coretemp.c Message-ID: <20140110162226.GA8582@roeck-us.net> References: <1389366623-26552-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1389366623-26552-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2014 at 10:10:23AM -0500, Paul Gortmaker wrote: > Commit da9e8c7a7b99b245c464ff45c7bde38a4b510019 ("hwmon: (coretemp) > Use PCI host bridge ID to identify CPU if necessary") added a new > instance of the __cpuinit macro usage. > > We removed this a couple versions ago; we now want to remove > the compat no-op stubs. Introducing new users is not what > we want to see at this point in time, as it will break once > the stubs are gone. > > Cc: Guenter Roeck > Signed-off-by: Paul Gortmaker > --- > > [Patch based on today's linux-next tree, so if hwmon next content > gets rebased, then the above commit ID will be invalidated; if it > _does_ get rebased, then feel free to squash this fix into the orig.] > Hi Paul, thanks a lot for the fix. I rebased hwmon-next and removed __cpuinitconst from the original commit, so the problem should be gone in the next iteration of linux-next. Thanks, Guenter