From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <waiman.long@hp.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Aswin Chandramouleeswaran <aswin@hp.com>,
Scott J Norton <scott.norton@hp.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: SIGSEGV when using "perf record -g" with 3.13-rc* kernel
Date: Fri, 10 Jan 2014 21:10:20 +0100 [thread overview]
Message-ID: <20140110201020.GK7572@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52D04BE6.9050907@hp.com>
On Fri, Jan 10, 2014 at 02:37:10PM -0500, Waiman Long wrote:
> >@@ -641,7 +641,7 @@ no_context(struct pt_regs *regs, unsigned long error_code,
> >
> > /* Are we prepared to handle this kernel fault? */
> > if (fixup_exception(regs)) {
> >- if (current_thread_info()->sig_on_uaccess_error&& signal) {
> >+ if (!in_nmi()&& current_thread_info()->sig_on_uaccess_error&& signal) {
> > tsk->thread.trap_nr = X86_TRAP_PF;
> > tsk->thread.error_code = error_code | PF_USER;
> > tsk->thread.cr2 = address;
>
> Yes, this change fixed the error that I got. I no longer see SIGSEGV when I
> run the test.
Awesome, just send a more elaborate version that should have the same
effect.
> I did tried to back out your "perf: Fix arch_perf_out_copy_user default"
> patch, but it didn't fix the problem.
The culprit was: e00b12e64be9 ("perf/x86: Further optimize
copy_from_user_nmi()")
prev parent reply other threads:[~2014-01-10 20:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 15:29 Waiman Long
2014-01-10 16:58 ` Peter Zijlstra
2014-01-10 17:02 ` Peter Zijlstra
2014-01-10 17:41 ` Peter Zijlstra
2014-01-10 18:54 ` Andy Lutomirski
2014-01-10 19:43 ` Waiman Long
2014-01-10 19:56 ` Andy Lutomirski
2014-01-10 20:12 ` Peter Zijlstra
2014-01-10 20:06 ` Peter Zijlstra
2014-01-10 20:28 ` Andy Lutomirski
2014-01-15 15:33 ` Waiman Long
2014-01-16 13:39 ` [tip:perf/core] x86, mm, perf: Allow recursive faults from interrupts tip-bot for Peter Zijlstra
2014-01-17 18:10 ` Waiman Long
2014-01-17 19:17 ` Andy Lutomirski
2014-01-17 20:08 ` Waiman Long
2014-01-17 21:07 ` Andy Lutomirski
2014-01-10 19:37 ` SIGSEGV when using "perf record -g" with 3.13-rc* kernel Waiman Long
2014-01-10 20:10 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110201020.GK7572@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@ghostprotocols.net \
--cc=aswin@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=scott.norton@hp.com \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome