From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH REPOST] ARM: Fix regression in IXP4xx network drivers DMA masks.
Date: Sat, 11 Jan 2014 16:13:42 +0000 [thread overview]
Message-ID: <20140111161342.GM15937@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <m3d2k4x5vo.fsf@t19.piap.pl>
On Mon, Jan 06, 2014 at 08:33:15PM +0100, Krzysztof Hałasa wrote:
> Russell et al.,
>
> anything wrong with this fix?
Well, I don't understand why moving this code around fixes a problem.
After all, if PCI is enabled, then presumably common-pci.c will always
be built and run - it has to be for the PCI bus to be probed.
Oh, are you trying to use the platform notify callback to set the
DMA mask on statically defined platform devices? No, don't do that,
initialise it in the declarations instead.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
prev parent reply other threads:[~2014-01-11 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 8:27 Krzysztof Hałasa
2014-01-06 19:33 ` Krzysztof Hałasa
2014-01-11 16:13 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140111161342.GM15937@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=khalasa@piap.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®