From: Borislav Petkov <bp@alien8.de>
To: Qiaowei Ren <qiaowei.ren@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information
Date: Sun, 12 Jan 2014 10:30:13 +0100 [thread overview]
Message-ID: <20140112093013.GB3664@pd.tnic> (raw)
In-Reply-To: <1389518403-7715-5-git-send-email-qiaowei.ren@intel.com>
On Sun, Jan 12, 2014 at 05:20:03PM +0800, Qiaowei Ren wrote:
> This patch adds new fields about bound violation into siginfo
> structure. si_lower and si_upper are respectively lower bound
> and upper bound when bound violation is caused.
>
> These fields will be set in #BR exception handler by decoding
> the user instruction and constructing the faulting pointer.
> A userspace application can get violation address, lower bound
> and upper bound for bound violation from this new siginfo structure.
>
> Signed-off-by: Qiaowei Ren <qiaowei.ren@intel.com>
> ---
> arch/x86/include/asm/mpx.h | 39 +++++
> arch/x86/kernel/mpx.c | 289 ++++++++++++++++++++++++++++++++++++
This thing looks like a partial duplication of functionality which we
already have - inat.*/insn.*, etc.
It would be cleaner to integrate the mpx pieces into the existing x86
insn analysis code and use it instead of growing your own, IMHO.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-01-12 9:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 9:19 [PATCH 1/5] x86, mpx: add documentation on Intel MPX Qiaowei Ren
2014-01-12 9:20 ` [PATCH 2/5] x86, mpx: hook #BR exception handler to allocate bound tables Qiaowei Ren
2014-01-12 9:20 ` Borislav Petkov
2014-01-13 3:17 ` Ren Qiaowei
2014-01-13 10:38 ` Borislav Petkov
2014-01-17 14:47 ` Ren, Qiaowei
2014-01-17 16:47 ` Borislav Petkov
2014-01-17 16:51 ` H. Peter Anvin
2014-01-17 17:14 ` Steven Rostedt
2014-01-17 17:51 ` H. Peter Anvin
2014-01-19 12:50 ` Ren, Qiaowei
2014-01-17 17:10 ` Steven Rostedt
2014-01-17 16:31 ` H. Peter Anvin
2014-01-17 16:48 ` Borislav Petkov
2014-01-17 16:51 ` H. Peter Anvin
2014-01-17 16:56 ` Borislav Petkov
2014-01-17 16:58 ` H. Peter Anvin
2014-01-17 17:04 ` Borislav Petkov
2014-01-17 17:30 ` H. Peter Anvin
2014-01-17 18:23 ` Borislav Petkov
2014-01-17 18:25 ` H. Peter Anvin
2014-01-12 9:20 ` [PATCH 3/5] x86, mpx: add prctl commands PR_MPX_INIT, PR_MPX_RELEASE Qiaowei Ren
2014-01-12 9:20 ` [PATCH 4/5] x86, mpx: add MPX related opcodes to the x86 opcode map Qiaowei Ren
2014-01-17 19:04 ` H. Peter Anvin
2014-01-17 19:22 ` [tip:x86/mpx] x86, mpx: Add " tip-bot for Qiaowei Ren
2014-01-12 9:20 ` [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information Qiaowei Ren
2014-01-12 9:30 ` Borislav Petkov [this message]
2014-01-12 16:49 ` H. Peter Anvin
2014-01-12 17:03 ` Borislav Petkov
2014-01-12 17:06 ` H. Peter Anvin
2014-01-13 3:09 ` Ren Qiaowei
2014-01-13 8:22 ` Ren Qiaowei
2014-01-13 10:43 ` Borislav Petkov
2014-01-17 14:55 ` Ren, Qiaowei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112093013.GB3664@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qiaowei.ren@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome