From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>
Subject: Re: [PATCH] avr32: fix missing module.h causing build failure in mimc200/fram.c
Date: Sun, 12 Jan 2014 18:18:48 +0100 [thread overview]
Message-ID: <20140112171848.GB3773@samfundet.no> (raw)
In-Reply-To: <1389364179-18228-1-git-send-email-paul.gortmaker@windriver.com>
Around Fri 10 Jan 2014 09:29:39 -0500 or thereabout, Paul Gortmaker wrote:
> Causing this:
>
> In file included from arch/avr32/boards/mimc200/fram.c:13:
> include/linux/miscdevice.h:51: error: field 'list' has incomplete type
> include/linux/miscdevice.h:55: error: expected specifier-qualifier-list before 'mode_t'
> arch/avr32/boards/mimc200/fram.c:42: error: 'THIS_MODULE' undeclared here (not in a function)
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thank you for fixing, almost identical to Sergei Trofimovich patch, which
appeared first in my inbox.
Fix appended to the AVR32 tree.
> diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
> index 9764a1a1073e..c1466a872b9c 100644
> --- a/arch/avr32/boards/mimc200/fram.c
> +++ b/arch/avr32/boards/mimc200/fram.c
> @@ -11,6 +11,7 @@
> #define FRAM_VERSION "1.0"
>
> #include <linux/miscdevice.h>
> +#include <linux/module.h>
> #include <linux/proc_fs.h>
> #include <linux/mm.h>
> #include <linux/io.h>
--
mvh
Hans-Christian Egtvedt
prev parent reply other threads:[~2014-01-12 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 14:29 Paul Gortmaker
2014-01-12 17:18 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112171848.GB3773@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=fengguang.wu@intel.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®