mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: John Tobias <john.tobias.ph@gmail.com>
Cc: <rjw@rjwysocki.net>, <viresh.kumar@linaro.org>,
	<cpufreq@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel@pengutronix.de>,
	<linux@arm.linux.org.uk>, <linux-arm-kernel@lists.infradead.org>,
	<festevam@gmail.com>
Subject: Re: [PATCH v4 1/2] ARM: imx: add select on ARCH_MXC for cpufreq support
Date: Mon, 13 Jan 2014 11:20:45 +0800	[thread overview]
Message-ID: <20140113032043.GF23525@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1389321592-33220-1-git-send-email-john.tobias.ph@gmail.com>

On Thu, Jan 09, 2014 at 06:39:51PM -0800, John Tobias wrote:
> Moved ARCH_HAS_CPUFREQ, HAVE_IMX_ANATOP and PM_OPP on ARCH_MXC so that
> the user can enable the cpufreq support for iMX6Q and/or iMX6SL.

All I was asking is to move the following:

	select ARCH_HAS_CPUFREQ
	select ARCH_HAS_OPP
	select PM_OPP if PM

So leave HAVE_IMX_ANATOP out there, and only move the above ones please.

Shawn

> 
> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> ---
>  arch/arm/mach-imx/Kconfig | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 7a6e6f7..d6aa34d 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -1,5 +1,6 @@
>  config ARCH_MXC
>  	bool "Freescale i.MX family" if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
> +	select ARCH_HAS_CPUFREQ
>  	select ARCH_REQUIRE_GPIOLIB
>  	select ARM_CPU_SUSPEND if PM
>  	select ARM_PATCH_PHYS_VIRT
> @@ -9,8 +10,10 @@ config ARCH_MXC
>  	select GENERIC_ALLOCATOR
>  	select GENERIC_CLOCKEVENTS
>  	select GENERIC_IRQ_CHIP
> +	select HAVE_IMX_ANATOP if SOC_IMX6Q || SOC_IMX6SL
>  	select MIGHT_HAVE_CACHE_L2X0 if ARCH_MULTI_V6_V7
>  	select MULTI_IRQ_HANDLER
> +	select PM_OPP if PM
>  	select SOC_BUS
>  	select SPARSE_IRQ
>  	select USE_OF
> @@ -779,16 +782,14 @@ config	SOC_IMX53
>  
>  config SOC_IMX6Q
>  	bool "i.MX6 Quad/DualLite support"
> -	select ARCH_HAS_CPUFREQ
> -	select ARCH_HAS_OPP
> +	select ARCH_HAS_OPP	
>  	select ARM_ERRATA_754322
>  	select ARM_ERRATA_764369 if SMP
>  	select ARM_ERRATA_775420
>  	select ARM_GIC
>  	select CPU_V7
>  	select HAVE_ARM_SCU if SMP
> -	select HAVE_ARM_TWD if SMP
> -	select HAVE_IMX_ANATOP
> +	select HAVE_ARM_TWD if SMP	
>  	select HAVE_IMX_GPC
>  	select HAVE_IMX_MMDC
>  	select HAVE_IMX_SRC
> @@ -800,8 +801,7 @@ config SOC_IMX6Q
>  	select PINCTRL_IMX6Q
>  	select PL310_ERRATA_588369 if CACHE_PL310
>  	select PL310_ERRATA_727915 if CACHE_PL310
> -	select PL310_ERRATA_769419 if CACHE_PL310
> -	select PM_OPP if PM
> +	select PL310_ERRATA_769419 if CACHE_PL310	
>  
>  	help
>  	  This enables support for Freescale i.MX6 Quad processor.
> @@ -812,7 +812,6 @@ config SOC_IMX6SL
>  	select ARM_ERRATA_775420
>  	select ARM_GIC
>  	select CPU_V7
> -	select HAVE_IMX_ANATOP
>  	select HAVE_IMX_GPC
>  	select HAVE_IMX_MMDC
>  	select HAVE_IMX_SRC
> -- 
> 1.8.3.2
> 


  parent reply	other threads:[~2014-01-13  3:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-10  2:39 John Tobias
2014-01-10  2:39 ` [PATCH v4 2/2] cpufreq: imx6q-cpufreq driver depends on SOC_IMX6Q/SOC_IMX6SL John Tobias
2014-01-13  3:26   ` Shawn Guo
2014-01-13  4:55     ` John Tobias
2014-01-13  3:20 ` Shawn Guo [this message]
2014-01-13  4:54   ` [PATCH v4 1/2] ARM: imx: add select on ARCH_MXC for cpufreq support John Tobias
2014-01-13  6:01     ` Shawn Guo
2014-01-14 21:37       ` John Tobias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140113032043.GF23525@S2101-09.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=john.tobias.ph@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®