From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbaAOBQr (ORCPT ); Tue, 14 Jan 2014 20:16:47 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35785 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbaAOBQp (ORCPT ); Tue, 14 Jan 2014 20:16:45 -0500 Date: Tue, 14 Jan 2014 17:16:44 -0800 From: Andrew Morton To: David Rientjes Cc: Nathan Zimmer , Tang Chen , Wen Congyang , Kamezawa Hiroyuki , Yasuaki Ishimatsu , "Rafael J. Wysocki" , Hedi , Mike Travis , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] hotplug, memory: move register_memory_resource out of the lock_memory_hotplug Message-Id: <20140114171644.d7b97b0501708afbeae7c841@linux-foundation.org> In-Reply-To: References: <1389723874-32372-1-git-send-email-nzimmer@sgi.com> <20140114151340.004d25c00056d88f33cadda0@linux-foundation.org> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jan 2014 17:05:42 -0800 (PST) David Rientjes wrote: > On Tue, 14 Jan 2014, Andrew Morton wrote: > > > From: Andrew Morton > > Subject: mm/memory_hotplug.c: register_memory_resource() fixes > > > > - register_memory_resource() should not go BUG on ENOMEM. That's > > appropriate at system boot time, but not at memory-hotplug time. Fix. > > > > - register_memory_resource()'s caller is incorrectly replacing > > request_resource()'s -EBUSY with -EEXIST. Fix this by propagating > > errors appropriately. > > > > Unfortunately, -EEXIST is a special case return value for both > acpi_memory_enable_device() and hv_mem_hot_add(), so they would need to be > modified to agree concurrently with this change. blah, OK, thanks, I'll drop it.