From: Leif Lindholm <leif.lindholm@linaro.org>
To: Roy Franz <roy.franz@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Matt Fleming <matt.fleming@intel.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Patch Tracking <patches@linaro.org>,
Mark Salter <msalter@redhat.com>,
Grant Likely <grant.likely@linaro.org>,
Dave Martin <dave.martin@arm.com>
Subject: Re: [PATCH V6 6/8] Add EFI stub for ARM
Date: Wed, 15 Jan 2014 11:47:00 +0000 [thread overview]
Message-ID: <20140115114700.GI30907@bivouac.eciton.net> (raw)
In-Reply-To: <CAFECyb9jbVHjM7--tRgbjfS9_MaAAvOhR3qXEKPKS6eW23V9Kg@mail.gmail.com>
On Tue, Jan 14, 2014 at 06:16:58PM -0800, Roy Franz wrote:
> >>> + .align 3
> >>> +pe_header:
> >>> + .ascii "PE"
> >>> + .short 0
> >>> +
> >>> +coff_header:
> >>> + .short 0x01c2 @ ARM or Thumb
> >>
> >> Could you explain why you are using 0x1c2 (Thumb) here and not 0x1c0 (ARM) ?
> >
> > Nope. It should be 0x1c0.
>
> OK, now I resolved the nagging feeling that I had already fixed
> this... Right now, the EDK2 UEFI implementation
> requires the machine type for ARM to be "0x1c2". I don't think that
> this is correct, but correcting this in EDK2 slipped through
> the cracks, but is now back on my todo list.
Nope, it should be 0x1c2.
0x1c0 is the COFF code for ARM only, which corresponds roughly with
OABI - which is not supported (and never will be) by the UEFI
specification.
0x1c2 means ARM or Thumb (Interworking), which is what we have.
The UEFI specification (correctly) neglects to even mention 0x1c0
and 0x1c4.
Do also note that the COFF information relates to the executable,
the stub. The rest of the kernel image is just a blob as far as UEFI
is concerned.
> I think that for now we should leave this as 0x1c2 so that the
> unpatched EDK2 builds will boot it, and some time after EDK2 is
> updated
> this can be changed. I'll work on a patch for EDK2 and get the
> discussion going on that list to resolve this in EDK2.
No need.
/
Leif
next prev parent reply other threads:[~2014-01-15 11:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 16:30 [PATCH V6 0/8] Add ARM EFI stub Roy Franz
2014-01-10 16:30 ` [PATCH V6 1/8] efi-stub.txt updates for ARM Roy Franz
2014-01-10 16:30 ` [PATCH V6 2/8] Add shared printk wrapper for consistent prefixing Roy Franz
2014-01-10 16:30 ` [PATCH V6 3/8] Add helper function to get and convert EFI command line Roy Franz
2014-01-13 15:04 ` Matt Fleming
2014-01-14 19:41 ` Roy Franz
2014-01-10 16:30 ` [PATCH V6 4/8] Add shared FDT related functions for ARM/ARM64 Roy Franz
2014-01-10 16:30 ` [PATCH V6 5/8] Add strstr to compressed string.c for ARM Roy Franz
2014-01-10 16:30 ` [PATCH V6 6/8] Add EFI stub " Roy Franz
2014-01-14 9:05 ` Ard Biesheuvel
2014-01-15 1:47 ` Roy Franz
2014-01-15 2:16 ` Roy Franz
2014-01-15 9:46 ` Ard Biesheuvel
2014-01-15 11:47 ` Leif Lindholm [this message]
2014-01-14 19:29 ` Rob Herring
2014-01-14 19:35 ` Roy Franz
2014-01-10 16:30 ` [PATCH V6 7/8] Disable stack protection for decompressor/stub Roy Franz
2014-01-10 16:30 ` [PATCH V6 8/8] Add config EFI_STUB for ARM to Kconfig Roy Franz
2014-01-13 15:07 ` [PATCH V6 0/8] Add ARM EFI stub Matt Fleming
2014-01-14 19:39 ` Roy Franz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115114700.GI30907@bivouac.eciton.net \
--to=leif.lindholm@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=dave.martin@arm.com \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt.fleming@intel.com \
--cc=msalter@redhat.com \
--cc=patches@linaro.org \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®