mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Alex Shi <alex.shi@linaro.org>,
	mingo@redhat.com, tglx@linutronix.de, vincent.guittot@linaro.org,
	morten.rasmussen@arm.com, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, fengguang.wu@intel.com,
	linaro-kernel@lists.linaro.org,
	Michael wang <wangyun@linux.vnet.ibm.com>
Subject: Re: [RFC PATCH] sched: find the latest idle cpu
Date: Thu, 16 Jan 2014 12:38:01 +0100	[thread overview]
Message-ID: <20140116113801.GN31570@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <52D7BC71.9010908@linaro.org>

On Thu, Jan 16, 2014 at 12:03:13PM +0100, Daniel Lezcano wrote:
> Hi Alex,
> 
> it is a nice optimization attempt but I agree with Peter we should focus on
> integrating cpuidle.
> 
> The question is "how do we integrate cpuidle ?"
> 
> IMHO, the main problem are the governors, especially the menu governor.

Yah.

> The menu governor tries to predict the events per cpu. This approach which
> gave us a nice benefit for the power saving may not fit well for the
> scheduler.

So the way to start all this is I think to gradually share more and
more.

Start by pulling in the actual idle state; such that we can indeed
observe what the relative cost is of waking a cpu (against another), and
maybe even the predicted wakeup time.

Then pull in the various statistics gathering bits -- without improving
them.

Then improve the statistics; try and remove duplicate statistics -- if
there's such things, try and use the extra information the scheduler has
etc..

Then worry about the governors, or what's left of them.

> In order to finish integrating the cpuidle framework in the scheduler, there
> are pending questions about the impact in the current design.
> 
> Peter or Ingo, if you have time, could you have a look at the email I sent
> previously [1] ?

I read it once, it didn't make sense at the time, I just read it again,
still doesn't make sense.

We need the idle task, since we need to DO something to go idle, the
scheduler needs to pick a task to go do that something. This is the idle
task.

You cannot get rid of that.

In fact, the 'doing' of that task is running much of the cpuidle code,
so by getting rid of it, there's nobody left to execute that code.

Also, since its already running that cpuidle stuff, integrating it more
closely with the scheduler will not in fact change much, it will still
run it.

Could of course be I'm not reading what you meant to write, if so, do
try again ;-)

  reply	other threads:[~2014-01-16 11:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15  4:07 Alex Shi
2014-01-15  4:31 ` Michael wang
2014-01-15  4:48   ` Alex Shi
2014-01-15  4:53     ` Alex Shi
2014-01-15  5:06       ` Alex Shi
2014-01-15  5:33 ` Michael wang
2014-01-15  6:45   ` Alex Shi
2014-01-15  8:05     ` Michael wang
2014-01-15 14:28       ` Alex Shi
2014-01-15  7:35 ` Peter Zijlstra
2014-01-15 14:37   ` Alex Shi
2014-01-16 11:03     ` Daniel Lezcano
2014-01-16 11:38       ` Peter Zijlstra [this message]
2014-01-16 12:16         ` Daniel Lezcano
2014-01-17  2:40           ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116113801.GN31570@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=fengguang.wu@intel.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=wangyun@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome