From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbaAQUaa (ORCPT ); Fri, 17 Jan 2014 15:30:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48665 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbaAQUa2 (ORCPT ); Fri, 17 Jan 2014 15:30:28 -0500 Date: Fri, 17 Jan 2014 21:29:51 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Greg KH Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, joro@8bytes.org, pbonzini@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH] KVM: SVM: fix NMI window after iret Message-ID: <20140117202950.GA10616@hpx.cz> References: <1389988362-15260-1-git-send-email-rkrcmar@redhat.com> <20140117201831.GA20561@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140117201831.GA20561@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-01-17 12:18-0800, Greg KH: > On Fri, Jan 17, 2014 at 08:52:42PM +0100, Radim Krčmář wrote: > > We should open NMI window right after an iret, but SVM exits before it. > > We wanted to single step using the trap flag and then open it. > > (or we could emulate the iret instead) > > We don't do it since commit 3842d135ff2 (likely), because the iret exit > > handler does not request an event, so NMI window remains closed until > > the next exit. > > > > Fix this by making KVM_REQ_EVENT request in the iret handler. > > > > Signed-off-by: Radim Krčmář > > --- > > (btw. kvm-unit-tests weren't executed on SVM since Nov 2010, at least) > > > > arch/x86/kvm/svm.c | 1 + > > 1 file changed, 1 insertion(+) > > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > Welp, at the last second, I decided it is not that critical to have it in stable and forgot to clean the git-send-email command line too. Please ignore this patch in stable.