From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753634AbaAQVYO (ORCPT ); Fri, 17 Jan 2014 16:24:14 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:32982 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbaAQVYM (ORCPT ); Fri, 17 Jan 2014 16:24:12 -0500 Date: Fri, 17 Jan 2014 22:24:10 +0100 From: Pavel Machek To: Julia Lawall Cc: ath9k-devel@venema.h4ckr.net, kernel-janitors@vger.kernel.org, ath5k-devel@venema.h4ckr.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "John W. Linville" , users@rt2x00.serialmonkey.com Subject: Re: [PATCH 0/11] use ether_addr_equal_64bits Message-ID: <20140117212410.GA13930@amd.pavel.ucw.cz> References: <1388427307-8691-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1388427307-8691-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2013-12-30 19:14:56, Julia Lawall wrote: > Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be > used when each argument is an array within a structure that contains at > least two bytes of data beyond the array. I mean, yes, it is probably faster, and yes, most structures probably contain two more bytes, but... is the uglyness worth the speedup? I'd say this should not be done except in very time-critical places... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html