From: "Chen, Gong" <gong.chen@linux.intel.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Michel Lespinasse <walken@google.com>,
Seiji Aguchi <seiji.aguchi@hds.com>,
Yang Zhang <yang.z.zhang@Intel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Janet Morgan <janet.morgan@Intel.com>,
Tony Luck <tony.luck@Intel.com>, Ruiv Wang <ruiv.wang@gmail.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
x86@kernel.org, Fengguang Wu <fengguang.wu@Intel.com>
Subject: Re: [PATCH] x86, cpu hotplug, use cpumask stack safe variant cpumask_var_t in check_irq_vectors_for_cpu_disable()
Date: Mon, 20 Jan 2014 03:50:17 -0500 [thread overview]
Message-ID: <20140120085017.GB5243@gchen.bj.intel.com> (raw)
In-Reply-To: <1389965961-14975-1-git-send-email-prarit@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
On Fri, Jan 17, 2014 at 08:39:21AM -0500, Prarit Bhargava wrote:
[...]
> +
> + if (!alloc_cpumask_var(&online_new, GFP_KERNEL)){
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + if (!alloc_cpumask_var(&affinity_new, GFP_KERNEL)) {
> + ret = -ENOMEM;
> + goto free_online_new;
> + }
>
This function is protected by stop_machine, which means the interrupts have
been disabled, so GFP_KERNEL is not reliable.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-20 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 13:39 Prarit Bhargava
2014-01-20 8:50 ` Chen, Gong [this message]
2014-01-20 18:57 ` [PATCH] x86, cpu hotplug, use cpumask stack safe variant cpumask_var_t in check_irq_vectors_for_cpu_disable() [v2] Prarit Bhargava
2014-01-22 2:00 ` Chen, Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120085017.GB5243@gchen.bj.intel.com \
--to=gong.chen@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=fengguang.wu@Intel.com \
--cc=hpa@linux.intel.com \
--cc=janet.morgan@Intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=prarit@redhat.com \
--cc=ruiv.wang@gmail.com \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@Intel.com \
--cc=walken@google.com \
--cc=x86@kernel.org \
--cc=yang.z.zhang@Intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome