mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Jens Axboe <axboe@kernel.dk>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kent Overstreet <kmo@daterainc.com>
Subject: linux-next: build failure after merge of the target-updates tree
Date: Mon, 20 Jan 2014 16:25:24 +1100	[thread overview]
Message-ID: <20140120162524.82964f2972d8933ce05e4df4@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 3104 bytes --]

Hi Nicholas,

After merging the target-updates tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/target/target_core_iblock.c: In function 'iblock_alloc_bip':
drivers/target/target_core_iblock.c:646:5: error: 'struct bio_integrity_payload' has no member named 'bip_size'
  bip->bip_size = (cmd->data_length / dev->dev_attrib.block_size) *
     ^
drivers/target/target_core_iblock.c:648:5: error: 'struct bio_integrity_payload' has no member named 'bip_sector'
  bip->bip_sector = bio->bi_sector;
     ^
drivers/target/target_core_iblock.c:648:23: error: 'struct bio' has no member named 'bi_sector'
  bip->bip_sector = bio->bi_sector;
                       ^
In file included from include/linux/printk.h:243:0,
                 from include/linux/kernel.h:13,
                 from include/linux/cache.h:4,
                 from include/linux/time.h:4,
                 from include/linux/ktime.h:24,
                 from include/linux/timer.h:5,
                 from drivers/target/target_core_iblock.c:29:
drivers/target/target_core_iblock.c:650:52: error: 'struct bio_integrity_payload' has no member named 'bip_size'
  pr_debug("IBLOCK BIP Size: %u Sector: %llu\n", bip->bip_size,
                                                    ^
drivers/target/target_core_iblock.c:651:27: error: 'struct bio_integrity_payload' has no member named 'bip_sector'
    (unsigned long long)bip->bip_sector);
                           ^

Caused by commit ecebbf6ccbca ("target/iblock: Add blk_integrity + BIP
passthrough support") interacting with commits 4f024f3797c4 ("block:
Abstract out bvec iterator") and d57a5f7c6605 ("bio-integrity: Convert to
bvec_iter") from the block tree.

I applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 20 Jan 2014 16:21:31 +1100
Subject: [PATCH] tagtet/iblock: merge for for bvec_iter changes

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/target/target_core_iblock.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index b7c64ef78338..554d4f75a75a 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -643,12 +643,12 @@ iblock_alloc_bip(struct se_cmd *cmd, struct bio *bio)
 		return -ENOMEM;
 	}
 
-	bip->bip_size = (cmd->data_length / dev->dev_attrib.block_size) *
+	bip->bip_iter.bi_size = (cmd->data_length / dev->dev_attrib.block_size) *
 			 dev->prot_length;
-	bip->bip_sector = bio->bi_sector;
+	bip->bip_iter.bi_sector = bio->bi_iter.bi_sector;
 
-	pr_debug("IBLOCK BIP Size: %u Sector: %llu\n", bip->bip_size,
-		 (unsigned long long)bip->bip_sector);
+	pr_debug("IBLOCK BIP Size: %u Sector: %llu\n", bip->bip_iter.bi_size,
+		 (unsigned long long)bip->bip_iter.bi_sector);
 
 	for_each_sg(cmd->t_prot_sg, sg, cmd->t_prot_nents, i) {
 
-- 
1.8.5.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2014-01-20  5:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20  5:25 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-10-07  3:49 Stephen Rothwell
2015-10-07 12:27 ` Alexander Shishkin
2015-10-07 20:22   ` Stephen Rothwell
2015-06-03  8:16 Stephen Rothwell
2015-06-03 20:00 ` James Bottomley
2015-06-03 22:12   ` Nicholas A. Bellinger
2015-06-03 22:33     ` James Bottomley
2015-06-03 22:46       ` Nicholas A. Bellinger
2015-05-12  4:54 Stephen Rothwell
2014-10-03  5:46 Stephen Rothwell
2014-10-03  8:10 ` Nicholas A. Bellinger
2014-05-23  9:11 Stephen Rothwell
2014-05-23 17:38 ` Nicholas A. Bellinger
2012-09-17  3:41 Stephen Rothwell
2012-09-18  0:57 ` Nicholas A. Bellinger
2012-02-10  0:50 Stephen Rothwell
2012-02-10  1:33 ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140120162524.82964f2972d8933ce05e4df4@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=axboe@kernel.dk \
    --cc=kmo@daterainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®