From: Jiri Olsa <jolsa@redhat.com>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tests: Add install prefix tests
Date: Wed, 22 Jan 2014 15:44:53 +0100 [thread overview]
Message-ID: <20140122144453.GB31858@krava.brq.redhat.com> (raw)
In-Reply-To: <CA+5PVA5QjRbkK2zScYvDj5FcvJ5iTmDWsp3Bhvndv-FYmeQwag@mail.gmail.com>
On Wed, Jan 22, 2014 at 09:03:21AM -0500, Josh Boyer wrote:
> On Wed, Jan 22, 2014 at 8:02 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Tue, Jan 21, 2014 at 07:58:41PM -0500, Josh Boyer wrote:
> >> On Tue, Jan 21, 2014 at 3:02 PM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
> >> > Hi All,
> >> >
> >> > I went to build Linux v3.13-737-g7fe67a1 in Fedora this morning and it
> >> > resulted in RPM complaining that the perf and perf.so binaries had
> >>
> >
> > SNIP
> >
> >> I'm not sure why DESTDIR is included in the -DPLUGIN_DIR definition in
> >> tools/lib/traceevent/Makefile, nor why $(prefix) is in plugindir_SQ in
> >> tools/perf/config/Makefile.
> >>
> >> josh
> >>
> >> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> >> index 56d52a3..005c9cc 100644
> >> --- a/tools/lib/traceevent/Makefile
> >> +++ b/tools/lib/traceevent/Makefile
> >> @@ -63,7 +63,7 @@ endif
> >> endif
> >>
> >> ifeq ($(set_plugin_dir),1)
> >> -PLUGIN_DIR = -DPLUGIN_DIR="$(DESTDIR)/$(plugin_dir)"
> >> +PLUGIN_DIR = -DPLUGIN_DIR="$(plugin_dir)"
> >> PLUGIN_DIR_SQ = '$(subst ','\'',$(PLUGIN_DIR))'
> >
> > hi,
> > this one needs to stay, otherwise perf have wrong path
> > to load plugins from..
>
> Hm. Are you sure? I believe I tested with just the $(prefix) removed
> below and it still failed the RPM build. If DESTDIR is included in
> what is passed as DPLUGIN_DIR, it will include the buildroot path in
> the binaries, but when the RPM is installed it does not install to the
> buildroot path. E.g. you will have:
>
> -DPLUGIN_DIR="/home/jwboyer/rpmbuild/BUILDROOT/kernel-3.14.0-0.rc0.git1.1.fc21.x86_64//usr/lib64/traceevent/plugins"
>
> but the plugins will be installed to /usr/lib64/traceevent/plugins by
> RPM. I'll try again with just the libdir fix, but I'm fairly sure
> what I've said above is correct. At least in terms of how RPMs are
> built.
ok, now I'm woken up... you're right, both hunks are needed,
got confused with the DESTDIR real meaning, sry
jirka
next prev parent reply other threads:[~2014-01-22 14:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 20:02 Weird plugin paths in perf and perf.so binaries with 3.14 merge window Josh Boyer
2014-01-22 0:58 ` Josh Boyer
2014-01-22 13:02 ` [PATCH] perf tests: Add install prefix tests Jiri Olsa
2014-01-22 14:03 ` Josh Boyer
2014-01-22 14:44 ` Jiri Olsa [this message]
2014-01-22 14:46 ` Josh Boyer
2014-01-22 11:36 ` Weird plugin paths in perf and perf.so binaries with 3.14 merge window Jiri Olsa
2014-01-27 5:14 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122144453.GB31858@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®