From: Markus Pargmann <mpa@pengutronix.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chris Ruehl <chris.ruehl@gtsys.com.hk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm@lists.infradead.org
Subject: Re: [PATCH 2/2 v2] imx27: pinctrl: fix offset calculation in imx_read_2bit
Date: Thu, 23 Jan 2014 11:57:32 +0100 [thread overview]
Message-ID: <20140123105732.GD25016@pengutronix.de> (raw)
In-Reply-To: <CACRpkdbWY8Ny0wNo0tM9WWG4uB2xOKV6zvFcqJ__qbku9VRN9g@mail.gmail.com>
Hi,
On Thu, Jan 23, 2014 at 09:26:06AM +0100, Linus Walleij wrote:
> On Wed, Jan 22, 2014 at 4:14 AM, Chris Ruehl <chris.ruehl@gtsys.com.hk> wrote:
>
> > The offset for the 2bit register calculate wrong, this patch
> > fixes the problem. The debugfs printout for oconf, iconfa, iconfb
> > now shows the real values.
> >
> > Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
>
> Markus: this OK? I want your review tag on it.
Yes this one is also ok.
Reviewed-by: Markus Pargmann <mpa@pengutronix.de>
Regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-01-23 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 3:14 [PATCH 1/2 v2] imx27: pinctrl: fix wrong offset to ICONFB Chris Ruehl
2014-01-22 3:14 ` [PATCH 2/2 v2] imx27: pinctrl: fix offset calculation in imx_read_2bit Chris Ruehl
2014-01-23 8:26 ` Linus Walleij
2014-01-23 10:57 ` Markus Pargmann [this message]
2014-01-31 8:20 ` Linus Walleij
2014-01-23 8:25 ` [PATCH 1/2 v2] imx27: pinctrl: fix wrong offset to ICONFB Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123105732.GD25016@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=chris.ruehl@gtsys.com.hk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®