From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Rodrigo Campos <rodrigo@sdfg.com.ar>,
Andi Kleen <andi@firstfloor.org>, Arun Sharma <asharma@fb.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v6)
Date: Thu, 23 Jan 2014 10:00:16 -0300 [thread overview]
Message-ID: <20140123130016.GA17572@ghostprotocols.net> (raw)
In-Reply-To: <20140123125009.GA1491@krava.brq.redhat.com>
Em Thu, Jan 23, 2014 at 01:50:10PM +0100, Jiri Olsa escreveu:
> On Wed, Jan 22, 2014 at 11:44:33PM +0000, Namhyung Kim wrote:
> > On Wed, Jan 22, 2014 at 1:20 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > > I have changes on top of this patchset and all looks great, I was
> > > just going throught this again and wanted to send my ack, but it
> > > no longer merges to the acme's perf/core.
> > Thanks, but wasn't it applied to the acme/perf/core? Now I'm rebasing
> > it onto the acme/perf/core and it applies without any conflicts. Did
> > you see one?
> hum, I just merged our v6 on acme's perf/core and got conflicts..
> not 100% sure the perf/core was clean though ;-)
I started to go thru this patchset yesterday, and made changes to code
that makes this patchset to not apply, I'll make the needed changes to
have a branch with it and will announce it here when done.
Till then I think tests can be done on Namhyung's git tree instead.
- Arnaldo
> > > Could you please send updated version, and I'll finish the
> > > review.. I promise ;-)
> >
> > Thanks in advance, I'll send out the v7 right soon. :)
>
> checking.. thanks,
> jirka
prev parent reply other threads:[~2014-01-23 13:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 5:25 Namhyung Kim
2014-01-14 5:25 ` [PATCH 01/24] perf tools: Remove symbol_conf.use_callchain check Namhyung Kim
2014-01-16 13:38 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-01-14 5:25 ` [PATCH 02/24] perf tools: Factor out sample__resolve_callchain() Namhyung Kim
2014-01-16 13:38 ` [tip:perf/core] perf tools: Factor out sample__resolve_callchain( ) tip-bot for Namhyung Kim
2014-01-14 5:25 ` [PATCH 03/24] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-01-14 5:25 ` [PATCH 04/24] perf hists: Convert hist entry functions to use struct he_stat Namhyung Kim
2014-01-16 13:38 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-01-14 5:25 ` [PATCH 05/24] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-01-14 5:25 ` [PATCH 06/24] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-01-14 5:25 ` [PATCH 07/24] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-01-14 5:25 ` [PATCH 08/24] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-01-14 5:25 ` [PATCH 09/24] perf report: Cache cumulative callchains Namhyung Kim
2014-01-14 5:25 ` [PATCH 10/24] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-01-14 5:25 ` [PATCH 11/24] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-01-14 5:25 ` [PATCH 12/24] perf hists: Sort hist entries by accumulated period Namhyung Kim
2014-01-14 5:25 ` [PATCH 13/24] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-01-14 5:25 ` [PATCH 14/24] perf ui/browser: " Namhyung Kim
2014-01-14 5:25 ` [PATCH 15/24] perf ui/gtk: " Namhyung Kim
2014-01-14 5:25 ` [PATCH 16/24] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-01-14 5:25 ` [PATCH 17/24] perf tools: Add more hpp helper functions Namhyung Kim
2014-01-14 5:25 ` [PATCH 18/24] perf report: Add --children option Namhyung Kim
2014-01-14 5:25 ` [PATCH 19/24] perf report: Add report.children config option Namhyung Kim
2014-01-14 5:25 ` [PATCH 20/24] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-01-14 5:25 ` [PATCH 21/24] perf top: Convert " Namhyung Kim
2014-01-14 5:25 ` [PATCH 22/24] perf top: Add --children option Namhyung Kim
2014-01-14 5:25 ` [PATCH 23/24] perf top: Add top.children config option Namhyung Kim
2014-01-14 5:25 ` [PATCH 24/24] perf tools: Enable --children option by default Namhyung Kim
2014-01-22 13:20 ` [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v6) Jiri Olsa
2014-01-22 18:03 ` Arun Sharma
2014-01-22 23:46 ` Namhyung Kim
2014-01-22 23:44 ` Namhyung Kim
2014-01-23 12:50 ` Jiri Olsa
2014-01-23 13:00 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123130016.GA17572@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=asharma@fb.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome