From: Fabian Frederick <fabf@skynet.be>
To: linux-mtd@lists.infradead.org
Cc: akpm@linux-foundation.org, rdunlap@infradead.org,
joern@lazybastard.org, linux-kernel@vger.kernel.org,
ezequiel.garcia@free-electrons.com
Subject: [PATCH 3/4] mtd: block2mtd: check device size
Date: Thu, 23 Jan 2014 20:53:31 +0100 [thread overview]
Message-ID: <20140123205331.03314c6f82f24a6bb4b8ef53@skynet.be> (raw)
fixme applied : check device size is a multiple of erasesize.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/mtd/devices/block2mtd.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index 8071596..f0fd4fc 100644
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -209,7 +209,6 @@ static void block2mtd_free_device(struct block2mtd_dev *dev)
}
-/* FIXME: ensure that mtd->size % erase_size == 0 */
static struct block2mtd_dev *add_device(char *devname, int erase_size)
{
const fmode_t mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
@@ -250,6 +249,11 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
goto devinit_err1;
}
+ if ((long)dev->blkdev->bd_inode->i_size % erase_size) {
+ pr_err("erasesize muse be a divisor of device size\n");
+ goto devinit_err1;
+ }
+
mutex_init(&dev->write_mutex);
/* Setup the MTD structure */
--
1.8.1.4
next reply other threads:[~2014-01-23 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 19:53 Fabian Frederick [this message]
2014-01-29 10:04 ` Ezequiel Garcia
2014-01-29 12:51 ` Fabian Frederick
2014-03-06 8:54 ` Brian Norris
2014-03-06 10:13 ` Fabian Frederick
2014-03-06 11:20 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123205331.03314c6f82f24a6bb4b8ef53@skynet.be \
--to=fabf@skynet.be \
--cc=akpm@linux-foundation.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®