mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Alex Thorlton <athorlton@sgi.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
	Matt Fleming <matt.fleming@intel.com>
Subject: Re: [BUG] Linux 3.14 fails to boot with new EFI changes
Date: Thu, 23 Jan 2014 23:48:57 +0100	[thread overview]
Message-ID: <20140123224857.GG5868@pd.tnic> (raw)
In-Reply-To: <20140123221108.GL18196@sgi.com>

On Thu, Jan 23, 2014 at 04:11:08PM -0600, Alex Thorlton wrote:
> We've been hitting the following bug in the latest kernel, during boot:

Can you merge

git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git#next

into your tree, enable CONFIG_EFI_PGT_DUMP, apply the debugging patch
below, catch the whole dmesg and send it to me (privately is fine too)?

Thanks.

---
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index f35c66c5959a..07712b9b4263 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -348,7 +348,12 @@ static void __init __init_extra_mapping(unsigned long phys, unsigned long size,
 						_PAGE_USER));
 		}
 		pmd = pmd_offset(pud, phys);
-		BUG_ON(!pmd_none(*pmd));
+		if (!pmd_none(*pmd)) {
+			pr_err("phys: 0x%lx, PGD: 0x%lx, PUD: 0x%lx, PMD: 0x%lx\n",
+				phys, pgd_val(*pgd), pud_val(*pud), pmd_val(*pmd));
+			BUG();
+		}
+
 		set_pmd(pmd, __pmd(phys | pgprot_val(prot)));
 	}
 }
--

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2014-01-23 22:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 22:11 Alex Thorlton
2014-01-23 22:48 ` Borislav Petkov [this message]
     [not found] <52E2ADB1.2030007@zytor.com>
     [not found] ` <20140124183730.GC11788@pd.tnic>
     [not found]   ` <20140124184842.GD11788@pd.tnic>
     [not found]     ` <20140124191709.GT18196@sgi.com>
     [not found]       ` <20140127222129.GK6839@pd.tnic>
     [not found]         ` <20140128110552.GA815@pd.tnic>
     [not found]           ` <20140128200754.GZ18196@sgi.com>
     [not found]             ` <20140128225905.GN815@pd.tnic>
     [not found]               ` <20140128234036.GB18196@sgi.com>
     [not found]                 ` <20140129141822.GC24887@pd.tnic>
2014-01-30 22:19                   ` Alex Thorlton
2014-01-30 22:23                     ` H. Peter Anvin
2014-01-31 10:07                       ` Borislav Petkov
2014-01-31 14:02                         ` Russ Anderson
2014-01-31 14:23                           ` Borislav Petkov
2014-01-31 14:36                             ` Borislav Petkov
2014-02-05 21:45                             ` Alex Thorlton
2014-02-05 23:15                               ` Borislav Petkov
2014-02-11 22:19                                 ` Alex Thorlton
2014-02-11 22:36                                   ` Borislav Petkov
2014-01-31  8:04                     ` Matt Fleming
2014-01-31 13:53                       ` Russ Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140123224857.GG5868@pd.tnic \
    --to=bp@alien8.de \
    --cc=athorlton@sgi.com \
    --cc=bp@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome