From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 0/8] perf tools: kaslr fixes
Date: Sun, 26 Jan 2014 19:43:10 +0100 [thread overview]
Message-ID: <20140126184310.GB1126@krava.brq.redhat.com> (raw)
In-Reply-To: <1390576218-1463-1-git-send-email-adrian.hunter@intel.com>
On Fri, Jan 24, 2014 at 05:10:10PM +0200, Adrian Hunter wrote:
> Hi
>
> Here are some patches that improve perf tools
> handling of relocation.
>
> This has become an issue as mentioned in this
> thread:
>
> http://marc.info/?l=linux-kernel&m=139030004314756
>
>
> It looks like the changes I made to vmlinux and
> module mapping to allow object code to be read
> broke the symbol annotation for relocated kernels.
> The first patch fixes that.
>
> There were some other issues though:
> - ref_reloc_sym was not always set up
> - mustn't use kcore if the kernel has moved
> - kallsyms is not unique for a given
> buildid
>
> These things need more testing but I thought it was
> worth getting comments now.
>
>
> Adrian Hunter (8):
> perf tools: Fix symbol annotation for relocated kernel
> perf tools: Add kallsyms__get_function_start()
> perf tools: Add machine__get_kallsyms_filename()
> perf tools: Set up ref_reloc_sym in machine__create_kernel_maps()
> perf report: Get ref_reloc_sym from kernel map
> perf tools: Prevent the use of kcore if the kernel has moved
> perf tools: test does not need to set up ref_reloc_sym
> perf tools: Adjust kallsyms for relocated kernel
cannot say much for the code changes (look ok ;-) ), but
it fixed the issue for me
Tested-by: Jiri Olsa <jolsa@redhat.com>
jirka
prev parent reply other threads:[~2014-01-26 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 15:10 Adrian Hunter
2014-01-24 15:10 ` [PATCH 1/8] perf tools: Fix symbol annotation for relocated kernel Adrian Hunter
2014-01-24 15:10 ` [PATCH 2/8] perf tools: Add kallsyms__get_function_start() Adrian Hunter
2014-01-24 15:10 ` [PATCH 3/8] perf tools: Add machine__get_kallsyms_filename() Adrian Hunter
2014-01-24 15:10 ` [PATCH 4/8] perf tools: Set up ref_reloc_sym in machine__create_kernel_maps() Adrian Hunter
2014-01-24 15:10 ` [PATCH 5/8] perf report: Get ref_reloc_sym from kernel map Adrian Hunter
2014-01-24 15:10 ` [PATCH 6/8] perf tools: Prevent the use of kcore if the kernel has moved Adrian Hunter
2014-01-24 15:10 ` [PATCH 7/8] perf tools: test does not need to set up ref_reloc_sym Adrian Hunter
2014-01-24 15:10 ` [PATCH 8/8] perf tools: Adjust kallsyms for relocated kernel Adrian Hunter
2014-01-26 18:43 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140126184310.GB1126@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®