From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753431AbaA0IvB (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Jan 2014 03:51:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17275 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751059AbaA0IvA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Jan 2014 03:51:00 -0500
Date: Mon, 27 Jan 2014 09:49:58 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>, Arun Sharma <asharma@fb.com>,
        Rodrigo Campos <rodrigo@sdfg.com.ar>, Andi Kleen <andi@firstfloor.org>,
        David Ahern <dsahern@gmail.com>, Stephane Eranian <eranian@google.com>,
        Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 01/21] perf tools: Introduce struct hist_entry_iter
Message-ID: <20140127084958.GB1139@krava.brq.redhat.com>
References: <1390436045-16830-1-git-send-email-namhyung@kernel.org>
 <1390436045-16830-2-git-send-email-namhyung@kernel.org>
 <20140123144400.GD1180@krava.brq.redhat.com>
 <87txcq56co.fsf@sejong.aot.lge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87txcq56co.fsf@sejong.aot.lge.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 27, 2014 at 02:41:43PM +0900, Namhyung Kim wrote:
> On Thu, 23 Jan 2014 15:44:00 +0100, Jiri Olsa wrote:
> > On Thu, Jan 23, 2014 at 09:13:45AM +0900, Namhyung Kim wrote:
> >> There're some duplicate code when adding hist entries.  They are
> >> different in that some have branch info or mem info but generally do
> >> same thing.  So introduce new struct hist_entry_iter and add callbacks
> >> to customize each case in general way.
> >> 
> >> The new perf_evsel__add_entry() function will look like:
> >> 
> >>   iter->prepare_entry();
> >>   iter->add_single_entry();
> >> 
> >>   while (iter->next_entry())
> >>     iter->add_next_entry();
> >> 
> >>   iter->finish_entry();
> >> 
> >> This will help further work like the cumulative callchain patchset.
> 
> [SNIP]
> >> -	if (rep->hide_unresolved && !al->sym)
> >> -		return 0;
> >
> > this check seems to be missing in iter_add_single_mem_entry
> 
> Right.  But afaics it's duplicate as we already check it in
> process_sample_event().

ok.. missed that

jirka