From: Mark Brown <broonie@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] pinctrl: Avoid kasprintf/kfree
Date: Thu, 30 Jan 2014 20:50:00 +0000 [thread overview]
Message-ID: <20140130205000.GX22609@sirena.org.uk> (raw)
In-Reply-To: <1391114256.2422.71.camel@joe-AO722>
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
On Thu, Jan 30, 2014 at 12:37:36PM -0800, Joe Perches wrote:
> + char propname[9 + sizeof(int) * 2 + 4] = "pinctrl-";
I'm not sure this is a triumph of legibility - there's several magic
numbers there and it's not blindlingly obvious where the caclculation
came from. Is this really a hot enough code path to benefit from an
optimisation like this?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-30 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 18:57 [PATCH] pinctrl: Quiet logging about missing DT nodes when not using DT Mark Brown
2014-01-30 19:04 ` Joe Perches
2014-01-30 20:37 ` [PATCH] pinctrl: Avoid kasprintf/kfree Joe Perches
2014-01-30 20:50 ` Mark Brown [this message]
2014-02-24 9:49 ` Linus Walleij
2014-02-24 18:16 ` Joe Perches
2014-02-24 9:45 ` [PATCH] pinctrl: Quiet logging about missing DT nodes when not using DT Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130205000.GX22609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=joe@perches.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®