From: Matt Fleming <matt@console-pimps.org>
To: Michel Lespinasse <walken@google.com>
Cc: Mike Waychison <mikew@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Matt Fleming <matt.fleming@intel.com>,
Tom Gundersen <teg@jklm.no>
Subject: Re: [PATCH 1/2] firmware: fix google/gsmi duplicate efivars_sysfs_init()
Date: Fri, 31 Jan 2014 09:46:15 +0000 [thread overview]
Message-ID: <20140131094615.GB29136@console-pimps.org> (raw)
In-Reply-To: <1390914382-3285-2-git-send-email-walken@google.com>
On Tue, 28 Jan, at 05:06:21AM, Michel Lespinasse wrote:
> Starting in commit e14ab23dde12b80db4c94b684a2e485b72b16af3,
> efivars_sysfs_init() is called both by itself as an init function,
> and by drivers/firmware/google/gsmi.c gsmi_init().
>
> This results in runtime warnings such as the following:
> [ 5.651330] WARNING: at fs/sysfs/dir.c:530 sysfs_add_one+0xbd/0xe0()
> [ 5.657699] sysfs: cannot create duplicate filename '/firmware/gsmi/vars'
>
> Fixing this by removing the redundant efivars_sysfs_init() call in
> gsmi_init().
>
> Tested: booted, checked that /firmware/gsmi/vars was still present and
> showed the expected contents.
>
> Signed-off-by: Michel Lespinasse <walken@google.com>
> ---
> drivers/firmware/google/gsmi.c | 7 -------
> 1 file changed, 7 deletions(-)
Oops, my bad.
(If it matters: Acked-by: Matt Fleming <matt.fleming@intel.com>)
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-01-31 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 13:06 [PATCH 0/2] Google firmware driver updates Michel Lespinasse
2014-01-28 13:06 ` [PATCH 1/2] firmware: fix google/gsmi duplicate efivars_sysfs_init() Michel Lespinasse
2014-01-31 9:46 ` Matt Fleming [this message]
2014-01-28 13:06 ` [PATCH 2/2] drivers-firmware: google memconsole driver fixes Michel Lespinasse
2014-01-28 18:36 ` [PATCH 0/2] Google firmware driver updates Mike Waychison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131094615.GB29136@console-pimps.org \
--to=matt@console-pimps.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mikew@google.com \
--cc=teg@jklm.no \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome