From: Mark Brown <broonie@kernel.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Kevin Hilman <khilman@linaro.org>,
Mike Turquette <mturquette@linaro.org>,
Emilio Lopez <emilio@elopez.com.ar>,
linux-sunxi@googlegroups.com, linux-spi@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kevin.z.m.zh@gmail.com, sunny@allwinnertech.com,
shuge@allwinnertech.com, zhuzhenhua@allwinnertech.com
Subject: Re: [PATCH v2 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver
Date: Fri, 31 Jan 2014 16:03:28 +0000 [thread overview]
Message-ID: <20140131160328.GI22609@sirena.org.uk> (raw)
In-Reply-To: <20140131081147.GC2950@lukather>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On Fri, Jan 31, 2014 at 09:11:47AM +0100, Maxime Ripard wrote:
> Wouldn't it be better if it was suspended by default, and just waken
> up whenever the framework needs it?
The aim should be to come out of probe in that state if runtime PM is
enabled but don't do it with these hacks, do it by idling the device
at the end of probe for example. Apart from anything else this code
just looks ugly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-31 16:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 11:10 [PATCH v2 0/5] Add Allwinner A31 SPI controller support Maxime Ripard
2014-01-29 11:10 ` [PATCH v2 1/5] clk: sunxi: Add support for PLL6 on the A31 Maxime Ripard
2014-01-29 11:10 ` [PATCH v2 2/5] ARM: sun6i: dt: Add PLL6 and SPI module clocks Maxime Ripard
2014-01-29 11:10 ` [PATCH v2 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver Maxime Ripard
2014-01-29 12:25 ` Mark Brown
2014-01-29 13:32 ` Maxime Ripard
2014-01-29 16:40 ` Mark Brown
2014-01-30 23:52 ` Kevin Hilman
2014-01-31 2:29 ` Felipe Balbi
2014-01-31 5:06 ` Kevin Hilman
2014-01-31 8:11 ` Maxime Ripard
2014-01-31 16:03 ` Mark Brown [this message]
2014-02-03 17:39 ` Kevin Hilman
2014-01-30 1:20 ` [linux-sunxi] " Emilio López
2014-01-29 11:10 ` [PATCH v2 4/5] ARM: sun6i: dt: Add SPI controllers to the A31 DTSI Maxime Ripard
2014-01-29 11:10 ` [PATCH v2 5/5] ARM: sunxi: Enable A31 SPI and SID in the defconfig Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131160328.GI22609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=kevin.z.m.zh@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@linaro.org \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
--cc=zhuzhenhua@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome