From: Mark Brown <broonie@kernel.org>
To: Matt Porter <mporter@linaro.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Tim Kryger <tim.kryger@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Christian Daudt <bcm@fixthebug.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux I2C List <linux-i2c@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] regulator: add bcm59056 regulator driver
Date: Tue, 4 Feb 2014 23:22:11 +0000 [thread overview]
Message-ID: <20140204232211.GE22609@sirena.org.uk> (raw)
In-Reply-To: <20140204212914.GB16179@beef>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Tue, Feb 04, 2014 at 04:29:14PM -0500, Matt Porter wrote:
> On Tue, Feb 04, 2014 at 05:28:36PM +0000, Mark Brown wrote:
> > > + /*
> > > + * Regulator API handles empty constraints but not NULL
> > > + * constraints
> > > + */
> > > + if (!reg_data)
> > > + continue;
> > It should do... if not then make it so since that'd mean most drivers
> > are buggy.
> Ahh, I see there is a check for NULL in the core. Will drop.
It was missing in some older kernels (much older now IIRC) - it's
possible that comment was written before this got fixed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-04 23:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 12:19 [PATCH 0/6] BCM59056 PMU regulator support Matt Porter
2014-02-04 12:19 ` [PATCH 1/6] i2c: bcm-kona: register with subsys_initcall Matt Porter
2014-02-05 9:08 ` Wolfram Sang
2014-02-05 15:18 ` Matt Porter
2014-02-05 15:30 ` Alan Stern
2014-02-05 16:19 ` Matt Porter
2014-02-04 12:19 ` [PATCH 2/6] regulator: add bcm59056 pmu DT binding Matt Porter
2014-02-04 17:23 ` Mark Brown
2014-02-04 21:16 ` Matt Porter
2014-02-04 23:21 ` Mark Brown
2014-02-04 12:19 ` [PATCH 3/6] mfd: add bcm59056 pmu driver Matt Porter
2014-02-04 13:29 ` Lee Jones
2014-02-04 14:31 ` Matt Porter
2014-02-04 14:47 ` Lee Jones
2014-02-04 15:01 ` Matt Porter
2014-02-04 15:20 ` Lee Jones
2014-02-04 16:59 ` Mark Brown
2014-02-04 17:08 ` Lee Jones
2014-02-04 17:11 ` Mark Brown
2014-02-04 12:19 ` [PATCH 4/6] regulator: add bcm59056 regulator driver Matt Porter
2014-02-04 17:28 ` Mark Brown
2014-02-04 21:29 ` Matt Porter
2014-02-04 23:22 ` Mark Brown [this message]
2014-02-04 12:19 ` [PATCH 5/6] ARM: configs: bcm_defconfig: enable bcm59056 regulator support Matt Porter
2014-02-04 12:19 ` [PATCH 6/6] ARM: dts: add bcm59056 pmu support and enable for bcm28155-ap Matt Porter
2014-02-04 13:40 ` [PATCH 0/6] BCM59056 PMU regulator support Lee Jones
2014-02-04 14:34 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204232211.GE22609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mporter@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=tim.kryger@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®