From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbaBGG3e (ORCPT ); Fri, 7 Feb 2014 01:29:34 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:40359 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbaBGG3d (ORCPT ); Fri, 7 Feb 2014 01:29:33 -0500 Date: Thu, 06 Feb 2014 22:29:32 -0800 (PST) Message-Id: <20140206.222932.292588043950970246.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: netdev@vger.kernel.org, rientjes@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: use __GFP_NORETRY for high order allocations From: David Miller In-Reply-To: <1391712162.10160.8.camel@edumazet-glaptop2.roam.corp.google.com> References: <1391712162.10160.8.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Thu, 06 Feb 2014 10:42:42 -0800 > From: Eric Dumazet > > sock_alloc_send_pskb() & sk_page_frag_refill() > have a loop trying high order allocations to prepare > skb with low number of fragments as this increases performance. > > Problem is that under memory pressure/fragmentation, this can > trigger OOM while the intent was only to try the high order > allocations, then fallback to order-0 allocations. > > We had various reports from unexpected regressions. > > According to David, setting __GFP_NORETRY should be fine, > as the asynchronous compaction is still enabled, and this > will prevent OOM from kicking as in : ... > Signed-off-by: Eric Dumazet > Acked-by: David Rientjes Applied, do we want this for -stable?