mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	"'Alessandro Zummo'" <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com
Subject: Re: [PATCH 01/10] rtc: rtc-at32ap700x: Remove unnecessary OOM messages
Date: Fri, 7 Feb 2014 09:04:16 +0100	[thread overview]
Message-ID: <20140207080416.GB18935@samfundet.no> (raw)
In-Reply-To: <000a01cf23da$e2b2e010$a818a030$%han@samsung.com>

Around Fri 07 Feb 2014 17:02:02 +0900 or thereabout, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.

Thanks for cleaning up.

> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

> ---
>  drivers/rtc/rtc-at32ap700x.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-at32ap700x.c b/drivers/rtc/rtc-at32ap700x.c
> index 3161ab5..aee3387 100644
> --- a/drivers/rtc/rtc-at32ap700x.c
> +++ b/drivers/rtc/rtc-at32ap700x.c
> @@ -204,10 +204,8 @@ static int __init at32_rtc_probe(struct platform_device *pdev)
>  
>  	rtc = devm_kzalloc(&pdev->dev, sizeof(struct rtc_at32ap700x),
>  			   GFP_KERNEL);
> -	if (!rtc) {
> -		dev_dbg(&pdev->dev, "out of memory\n");
> +	if (!rtc)
>  		return -ENOMEM;
> -	}
>  
>  	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!regs) {
-- 
mvh
Hans-Christian Egtvedt

  reply	other threads:[~2014-02-07  8:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07  8:00 [PATCH 00/10] rtc: " Jingoo Han
2014-02-07  8:02 ` [PATCH 01/10] rtc: rtc-at32ap700x: " Jingoo Han
2014-02-07  8:04   ` Hans-Christian Egtvedt [this message]
2014-02-07  8:02 ` [PATCH 02/10] rtc: rtc-davinci: " Jingoo Han
2014-02-07  8:03 ` [PATCH 03/10] rtc: rtc-ds1390: " Jingoo Han
2014-02-07  8:06 ` [PATCH 05/10] rtc: rtc-moxart: " Jingoo Han
2014-02-07  8:07 ` [PATCH 06/10] rtc: rtc-nuc900: " Jingoo Han
2014-02-07  8:09 ` [PATCH 07/10] rtc: rtc-pm8xxx: " Jingoo Han
2014-02-07  8:11 ` [PATCH 08/10] rtc: rtc-rx8025: " Jingoo Han
2014-02-07  8:12 ` [PATCH 09/10] rtc: rtc-sirfsoc: " Jingoo Han
2014-02-07 12:08   ` Barry Song
2014-02-07  8:14 ` [PATCH 04/10] rtc: rtc-lpc32xx: " Jingoo Han
2014-02-07  8:15 ` [PATCH 10/10] rtc: rtc-spear: " Jingoo Han
2014-02-07 10:07   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140207080416.GB18935@samfundet.no \
    --to=egtvedt@samfundet.no \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®