mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wang YanQing <udknight@gmail.com>,
	jslaby@suse.cz, airlied@redhat.com, akpm@linux-foundation.org,
	kilobyte@angband.pl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vt: initialize con_driver->node in con_init
Date: Fri, 7 Feb 2014 08:45:00 -0800	[thread overview]
Message-ID: <20140207164500.GB32655@kroah.com> (raw)
In-Reply-To: <20131230031102.GA4424@udknight>

On Mon, Dec 30, 2013 at 11:11:02AM +0800, Wang YanQing wrote:
> Commit 6db4063c5b72b46e9793b0f141a7a3984ac6facf
> ("[PATCH] VT binding: Add sysfs control to the VT layer")
> add node item into struct con_driver.

That commit was almost a decade ago, is this patch really needed?

> This patch initialize con_driver->node in con_init.

You are saying what it does, not _why_ it is needed or why this change
is happening.

Please rewrite this with more information because as-is, I have no idea
why I should accept this patch.

thanks,

greg k-h

  parent reply	other threads:[~2014-02-07 16:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30  3:11 Wang YanQing
2014-01-09  4:33 ` Greg KH
2014-02-07 16:45 ` Greg KH [this message]
2014-02-11  0:49   ` Wang YanQing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140207164500.GB32655@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=airlied@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=jslaby@suse.cz \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=udknight@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®